Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1492253002: Use content::TestBrowserThreadBundle in DownloadsListTracker unit_tests (Closed)

Created:
5 years ago by Dan Beam
Modified:
5 years ago
Reviewers:
dpapad
CC:
asanka, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@new-dl-data
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use content::TestBrowserThreadBundle in DownloadsListTracker unit_tests R=dpapad@chromium.org BUG=none TEST=less code Committed: https://crrev.com/aa2a5a499c073ac079f9f80ecbd208af26becc9f Cr-Commit-Position: refs/heads/master@{#363019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 1428833005 Patch 330001

Dependent Patchsets:

Issue 1496853002 Patch 20001

Messages

Total messages: 7 (2 generated)
Dan Beam
5 years ago (2015-12-03 06:04:22 UTC) #1
dpapad
lgtm
5 years ago (2015-12-03 17:46:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492253002/1
5 years ago (2015-12-03 18:35:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 18:47:02 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-03 18:47:51 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aa2a5a499c073ac079f9f80ecbd208af26becc9f
Cr-Commit-Position: refs/heads/master@{#363019}

Powered by Google App Engine
This is Rietveld 408576698