Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3085)

Unified Diff: chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc

Issue 1492253002: Use content::TestBrowserThreadBundle in DownloadsListTracker unit_tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new-dl-data
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc
diff --git a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc
index fef30f308a013ef76248f8a8901d51f955a3e680..9d279e4698aba8bc3f075c7268338715846066c0 100644
--- a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc
+++ b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc
@@ -8,14 +8,13 @@
#include "base/files/file_path.h"
#include "base/memory/scoped_ptr.h"
-#include "base/message_loop/message_loop.h"
#include "base/stl_util.h"
#include "base/time/time.h"
#include "chrome/browser/download/download_item_model.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/mock_download_item.h"
#include "content/public/test/mock_download_manager.h"
-#include "content/public/test/test_browser_thread.h"
+#include "content/public/test/test_browser_thread_bundle.h"
#include "content/public/test/test_web_ui.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -93,8 +92,7 @@ class TestDownloadsListTracker : public DownloadsListTracker {
// A fixture to test DownloadsListTracker.
class DownloadsListTrackerTest : public testing::Test {
public:
- DownloadsListTrackerTest()
- : ui_thread_(content::BrowserThread::UI, &message_loop_) {}
+ DownloadsListTrackerTest() {}
~DownloadsListTrackerTest() override {
for (auto* mock_item : mock_items_)
testing::Mock::VerifyAndClear(mock_item);
@@ -138,8 +136,7 @@ class DownloadsListTrackerTest : public testing::Test {
}
// NOTE: The initialization order of these members matters.
- base::MessageLoopForUI message_loop_;
- content::TestBrowserThread ui_thread_;
+ content::TestBrowserThreadBundle thread_bundle_;
TestingProfile profile_;
testing::NiceMock<content::MockDownloadManager> manager_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698