Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1496853002: MD Downloads: fix incognito markers (Closed)

Created:
5 years ago by Dan Beam
Modified:
5 years ago
Reviewers:
asanka, Charlie Reis
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@thread-bundle
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: fix incognito markers R=asanka@chromium.org BUG=566098 Committed: https://crrev.com/352a427c15a2b58515af6fd54b5b68e6ffb70b6f Cr-Commit-Position: refs/heads/master@{#363325}

Patch Set 1 : test #

Patch Set 2 : remove DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M chrome/browser/ui/webui/md_downloads/downloads_list_tracker.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M content/browser/browser_context.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Dan Beam
yup, now's where you insert a "I told you so" regarding testing incognito :)
5 years ago (2015-12-03 06:25:46 UTC) #2
Dan Beam
ping asanka
5 years ago (2015-12-04 08:00:08 UTC) #3
Dan Beam
+creis for content/
5 years ago (2015-12-04 17:37:03 UTC) #5
Charlie Reis
browser_context.cc looks like just dead code removal? content/ LGTM. Can you add a bug number? ...
5 years ago (2015-12-04 17:56:56 UTC) #6
Dan Beam
added https://code.google.com/p/chromium/issues/detail?id=566098
5 years ago (2015-12-04 18:08:35 UTC) #8
asanka
LGTM. ITYS.
5 years ago (2015-12-04 22:01:08 UTC) #9
Dan Beam
On 2015/12/04 22:01:08, asanka wrote: > LGTM. ITYS. :)
5 years ago (2015-12-04 22:34:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496853002/40001
5 years ago (2015-12-04 22:48:17 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years ago (2015-12-05 00:49:00 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-05 00:49:45 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/352a427c15a2b58515af6fd54b5b68e6ffb70b6f
Cr-Commit-Position: refs/heads/master@{#363325}

Powered by Google App Engine
This is Rietveld 408576698