Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1491893002: [proxies] Implement the Proxy constructor in C++ fully. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@BuiltinsExtraArguments
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Implement the Proxy constructor in C++ fully. The main part of the Proxy constructor was already in C++, there's actually no point in keeping a JavaScript wrapper. R=cbruni@chromium.org BUG=v8:1543 LOG=n Committed: https://crrev.com/2377170d076fc5d79688ce0a3863cf9179a79bfa Cr-Commit-Position: refs/heads/master@{#32507}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -38 lines) Patch
M src/bootstrapper.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/builtins.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 1 chunk +57 lines, -0 lines 0 comments Download
M src/js/proxy.js View 2 chunks +0 lines, -10 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-proxy.cc View 1 chunk +0 lines, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years ago (2015-12-02 11:57:02 UTC) #1
Benedikt Meurer
Hey Camillo, The move (plus fix) we talked about offline. Please take a look. Thanks, ...
5 years ago (2015-12-02 11:58:08 UTC) #2
Camillo Bruni
LGTM with nit. https://codereview.chromium.org/1491893002/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1491893002/diff/1/src/builtins.cc#newcode1758 src/builtins.cc:1758: // ES6 section 26.2.1.1 Proxy ( ...
5 years ago (2015-12-02 12:02:56 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1491893002/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1491893002/diff/1/src/builtins.cc#newcode1758 src/builtins.cc:1758: // ES6 section 26.2.1.1 Proxy ( target, handler ) ...
5 years ago (2015-12-02 12:07:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491893002/20001
5 years ago (2015-12-02 12:07:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 12:29:57 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-02 12:30:23 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2377170d076fc5d79688ce0a3863cf9179a79bfa
Cr-Commit-Position: refs/heads/master@{#32507}

Powered by Google App Engine
This is Rietveld 408576698