Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1491883002: [builtins] Some refactoring on the builtin mechanism. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Some refactoring on the builtin mechanism. Allow to pass new.target (in addition to target) to C++ builtins, and remove some obsolete/dangerous code from the C++ builtins. R=yangguo@chromium.org Committed: https://crrev.com/4013a8df54d2cd6073cb6a92446d95b9ca97c967 Cr-Commit-Position: refs/heads/master@{#32505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -213 lines) Patch
M src/arm/builtins-arm.cc View 2 chunks +17 lines, -6 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 2 chunks +17 lines, -6 lines 0 comments Download
M src/builtins.h View 2 chunks +47 lines, -40 lines 0 comments Download
M src/builtins.cc View 11 chunks +90 lines, -119 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +13 lines, -9 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +17 lines, -6 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 2 chunks +17 lines, -6 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 2 chunks +17 lines, -6 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M src/x87/builtins-x87.cc View 2 chunks +13 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-02 11:30:59 UTC) #1
Benedikt Meurer
Hey Yang, Here's some preliminary refactoring on the builtins to make it possible to move ...
5 years ago (2015-12-02 11:32:10 UTC) #2
Yang
On 2015/12/02 11:32:10, Benedikt Meurer wrote: > Hey Yang, > > Here's some preliminary refactoring ...
5 years ago (2015-12-02 11:34:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491883002/1
5 years ago (2015-12-02 11:34:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 12:01:26 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-02 12:01:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4013a8df54d2cd6073cb6a92446d95b9ca97c967
Cr-Commit-Position: refs/heads/master@{#32505}

Powered by Google App Engine
This is Rietveld 408576698