Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: src/bootstrapper.cc

Issue 1491893002: [proxies] Implement the Proxy constructor in C++ fully. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@BuiltinsExtraArguments
Patch Set: Address feedback. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/builtins.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index dc1e3ed9495b78b1fe31a00f54067e1fb61d335e..5c4c5a93e79e5bd5cb8438dd6832e3843fa6e5c2 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -2149,13 +2149,15 @@ void Genesis::InitializeGlobal_harmony_proxies() {
Handle<JSGlobalObject> global(
JSGlobalObject::cast(native_context()->global_object()));
Isolate* isolate = global->GetIsolate();
- Handle<JSFunction> proxy_fun =
- InstallFunction(global, "Proxy", JS_PROXY_TYPE, JSProxy::kSize,
- isolate->initial_object_prototype(), Builtins::kIllegal);
+ Handle<JSFunction> proxy_fun = InstallFunction(
+ global, "Proxy", JS_PROXY_TYPE, JSProxy::kSize,
+ isolate->initial_object_prototype(), Builtins::kProxyConstructor);
// TODO(verwaest): Set to null in InstallFunction.
proxy_fun->initial_map()->set_prototype(isolate->heap()->null_value());
proxy_fun->shared()->set_construct_stub(
- *isolate->builtins()->JSBuiltinsConstructStub());
+ *isolate->builtins()->ProxyConstructor_ConstructStub());
+ proxy_fun->shared()->set_internal_formal_parameter_count(2);
+ proxy_fun->shared()->set_length(2);
native_context()->set_proxy_function(*proxy_fun);
}
« no previous file with comments | « no previous file | src/builtins.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698