base/BUILD.gn - Issue 1491743009: [base] POSIX File::Unlock() didn't actually unlock file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/BUILD.gn

Issue 1491743009: [base] POSIX File::Unlock() didn't actually unlock file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move lock tests to new file, with test fixture, share code. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/BUILD.gn

diff --git a/base/BUILD.gn b/base/BUILD.gn

index 0841c6e9a974b8819ae1f41c35222db69f8c21bc..feb23078aa5511e81c0491200057a1d62987a5b1 100644

--- a/base/BUILD.gn

+++ b/base/BUILD.gn

@@ -1303,6 +1303,7 @@ test("base_unittests") {

"environment_unittest.cc",

"file_version_info_unittest.cc",

"files/dir_reader_posix_unittest.cc",

+ "files/file_locking_unittest.cc",

"files/file_path_unittest.cc",

"files/file_path_watcher_unittest.cc",

"files/file_proxy_unittest.cc",

@@ -1537,6 +1538,7 @@ test("base_unittests") {

if (is_ios) {

sources -= [

+ "files/file_locking_unittest.cc",

"files/file_path_watcher_unittest.cc",

"memory/discardable_shared_memory_unittest.cc",

"memory/shared_memory_unittest.cc",

« no previous file with comments | « no previous file | base/base.gyp » ('j') | base/files/file_locking_unittest.cc » ('J')