Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: base/BUILD.gn

Issue 1491743009: [base] POSIX File::Unlock() didn't actually unlock file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move lock tests to new file, with test fixture, share code. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/base.gyp » ('j') | base/files/file_locking_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/compiler/compiler.gni") 5 import("//build/config/compiler/compiler.gni")
6 import("//build/config/nacl/config.gni") 6 import("//build/config/nacl/config.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 import("//testing/test.gni") 8 import("//testing/test.gni")
9 9
10 if (is_android) { 10 if (is_android) {
(...skipping 1285 matching lines...) Expand 10 before | Expand all | Expand 10 after
1296 "debug/crash_logging_unittest.cc", 1296 "debug/crash_logging_unittest.cc",
1297 "debug/debugger_unittest.cc", 1297 "debug/debugger_unittest.cc",
1298 "debug/leak_tracker_unittest.cc", 1298 "debug/leak_tracker_unittest.cc",
1299 "debug/proc_maps_linux_unittest.cc", 1299 "debug/proc_maps_linux_unittest.cc",
1300 "debug/stack_trace_unittest.cc", 1300 "debug/stack_trace_unittest.cc",
1301 "debug/task_annotator_unittest.cc", 1301 "debug/task_annotator_unittest.cc",
1302 "deferred_sequenced_task_runner_unittest.cc", 1302 "deferred_sequenced_task_runner_unittest.cc",
1303 "environment_unittest.cc", 1303 "environment_unittest.cc",
1304 "file_version_info_unittest.cc", 1304 "file_version_info_unittest.cc",
1305 "files/dir_reader_posix_unittest.cc", 1305 "files/dir_reader_posix_unittest.cc",
1306 "files/file_locking_unittest.cc",
1306 "files/file_path_unittest.cc", 1307 "files/file_path_unittest.cc",
1307 "files/file_path_watcher_unittest.cc", 1308 "files/file_path_watcher_unittest.cc",
1308 "files/file_proxy_unittest.cc", 1309 "files/file_proxy_unittest.cc",
1309 "files/file_unittest.cc", 1310 "files/file_unittest.cc",
1310 "files/file_util_proxy_unittest.cc", 1311 "files/file_util_proxy_unittest.cc",
1311 "files/file_util_unittest.cc", 1312 "files/file_util_unittest.cc",
1312 "files/important_file_writer_unittest.cc", 1313 "files/important_file_writer_unittest.cc",
1313 "files/memory_mapped_file_unittest.cc", 1314 "files/memory_mapped_file_unittest.cc",
1314 "files/scoped_temp_dir_unittest.cc", 1315 "files/scoped_temp_dir_unittest.cc",
1315 "gmock_unittest.cc", 1316 "gmock_unittest.cc",
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
1530 ":base_java_unittest_support", 1531 ":base_java_unittest_support",
1531 ] 1532 ]
1532 1533
1533 # TODO(brettw) I think this should not be here, we should not be using 1534 # TODO(brettw) I think this should not be here, we should not be using
1534 # isolate files. 1535 # isolate files.
1535 isolate_file = "base_unittests.isolate" 1536 isolate_file = "base_unittests.isolate"
1536 } 1537 }
1537 1538
1538 if (is_ios) { 1539 if (is_ios) {
1539 sources -= [ 1540 sources -= [
1541 "files/file_locking_unittest.cc",
1540 "files/file_path_watcher_unittest.cc", 1542 "files/file_path_watcher_unittest.cc",
1541 "memory/discardable_shared_memory_unittest.cc", 1543 "memory/discardable_shared_memory_unittest.cc",
1542 "memory/shared_memory_unittest.cc", 1544 "memory/shared_memory_unittest.cc",
1543 "process/memory_unittest.cc", 1545 "process/memory_unittest.cc",
1544 "process/process_unittest.cc", 1546 "process/process_unittest.cc",
1545 "process/process_util_unittest.cc", 1547 "process/process_util_unittest.cc",
1546 "sync_socket_unittest.cc", 1548 "sync_socket_unittest.cc",
1547 ] 1549 ]
1548 1550
1549 # Pull in specific Mac files for iOS (which have been filtered out by file 1551 # Pull in specific Mac files for iOS (which have been filtered out by file
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
1750 1752
1751 # GYP: //base.gyp:base_java_unittest_support 1753 # GYP: //base.gyp:base_java_unittest_support
1752 android_library("base_java_unittest_support") { 1754 android_library("base_java_unittest_support") {
1753 deps = [ 1755 deps = [
1754 ":base_java", 1756 ":base_java",
1755 ] 1757 ]
1756 java_files = 1758 java_files =
1757 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ] 1759 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
1758 } 1760 }
1759 } 1761 }
OLDNEW
« no previous file with comments | « no previous file | base/base.gyp » ('j') | base/files/file_locking_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698