Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: base/base.gyp

Issue 1491743009: [base] POSIX File::Unlock() didn't actually unlock file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move lock tests to new file, with test fixture, share code. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index 69ff8bdd30e4e67809ed316c9d296c02855aa2f2..6fdbaf8cc896abd8e237171bdb38f08cc68f9b39 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -472,6 +472,7 @@
'feature_list_unittest.cc',
'file_version_info_unittest.cc',
'files/dir_reader_posix_unittest.cc',
+ 'files/file_locking_unittest.cc',
'files/file_path_unittest.cc',
'files/file_path_watcher_unittest.cc',
'files/file_proxy_unittest.cc',
@@ -699,6 +700,8 @@
}],
['OS == "ios" and _toolset != "host"', {
'sources/': [
+ # This test needs multiple processes.
+ ['exclude', '^files/file_locking_unittest\\.cc$'],
# iOS does not support FilePathWatcher.
['exclude', '^files/file_path_watcher_unittest\\.cc$'],
# Only test the iOS-meaningful portion of memory and process_utils.

Powered by Google App Engine
This is Rietveld 408576698