Linter should enforce Tests marked Slow or WontFix aren't allowed in TestExpectations

Linter should enforce Tests marked Slow or WontFix aren't allowed in TestExpectations

Tests marked Slow are only allowed in SlowTests,
Tests marked WontFix are only allowed in NeverFixTests,
These should not go into the TestExpectations file given there are
reserved files for them.

BUG=559390
Committed: https://crrev.com/a2f07ea5d0d9fd81a7b86089fa2826518f44fdad
Cr-Commit-Position: refs/heads/master@{#371179}

[nainar, 2015-12-04 04:13:47]

nainar@chromium.org changed reviewers:
+ ojan@chromium.org

[nainar, 2015-12-04 04:13:48]

Hi Ojan,

Could you take a look at the error message and let me know if we need to be
giving more information? 

Also I have moved the relevant expectations over to SlowTest and NeverFixTests.
Along this line, I wanted to ask if WontFix test expectations are allowed in
StaleTestExpectations? Or are they not?  Because the entries in
StaleTestExpectaions are only WontFix entries - the file is empty otherwise. 

I am working on the unit tests - I was hoping to get initial feedback. 

Thanks so much!

[ojan, 2016-01-22 02:11:41]

So sorry for the very delayed response here. This patch LGTM once you update the
lists in SlowTests, etc given changes that happened since you originally
uploaded.

If you'd be willing, it'd be great to do a followup patch that only allowed
using Slow in SlowTests (e.g. no Crash lines in SlowTests) and only allowed
using WontFix in NeverFixTests and StaleTestExpectations. That's the other
common mistake I see people making (e.g. there's an existing line in SlowTests
and they add to it).

[nainar, 2016-01-22 02:20:14]

Just wrapping up fixing some of the failing tests - should be done with it by
Monday. :)

Will work on the following stuff from then on.

[nainar, 2016-01-25 01:36:24]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 01:36:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491143003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491143003/60001

[commit-bot: I haz the power, 2016-01-25 02:27:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 02:27:24]

Dry run: This issue passed the CQ dry run.

[nainar, 2016-01-25 02:27:48]

The CQ bit was checked by nainar@chromium.org

[nainar, 2016-01-25 02:27:49]

The patchset sent to the CQ was uploaded after l-g-t-m from ojan@chromium.org
Link to the patchset: https://codereview.chromium.org/1491143003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-01-25 02:27:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491143003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491143003/60001

[commit-bot: I haz the power, 2016-01-25 02:34:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-25 02:35:40]

Description was changed from

==========
Linter should enforce Tests marked Slow or WontFix aren't allowed in
TestExpectations

Tests marked Slow are only allowed in SlowTests,
Tests marked WontFix are only allowed in NeverFixTests,
These should not go into the TestExpectations file given there are
reserved files for them.

BUG=559390
==========

to

==========
Linter should enforce Tests marked Slow or WontFix aren't allowed in
TestExpectations

Tests marked Slow are only allowed in SlowTests,
Tests marked WontFix are only allowed in NeverFixTests,
These should not go into the TestExpectations file given there are
reserved files for them.

BUG=559390

Committed: https://crrev.com/a2f07ea5d0d9fd81a7b86089fa2826518f44fdad
Cr-Commit-Position: refs/heads/master@{#371179}
==========

[commit-bot: I haz the power, 2016-01-25 02:35:40]

Patchset 4 (id:??) landed as
https://crrev.com/a2f07ea5d0d9fd81a7b86089fa2826518f44fdad
Cr-Commit-Position: refs/heads/master@{#371179}