third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_tests_mover_unittest.py - Issue 1491143003: Linter should enforce Tests marked Slow or WontFix aren't allowed in TestExpectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_tests_mover_unittest.py

Issue 1491143003: Linter should enforce Tests marked Slow or WontFix aren't allowed in TestExpectations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_tests_mover_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_tests_mover_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_tests_mover_unittest.py

index 7be0bbaa1e3577763b6528af720d6da7fabb02a4..e888a70641e611392daee858dbc1c71b0346d86c 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_tests_mover_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_tests_mover_unittest.py

@@ -49,7 +49,7 @@ class MockPort(base.Port):

host.filesystem.write_text_file(self._absolute_path('VirtualTestSuites'), '[]')

host.filesystem.write_text_file(self._absolute_path('TestExpectations'), """

crbug.com/42 [ Debug ] origin/path/test.html [ Pass Timeout Failure ]

-crbug.com/42 [ Win ] origin/path [ Slow ]

+crbug.com/42 [ Win ] origin/path [ Crash ]

crbug.com/42 [ Release ] origin [ Crash ]

""")

host.filesystem.write_text_file(self._absolute_path('existing_directory_with_contents', 'test.html'), '')

@@ -170,7 +170,7 @@ class LayoutTestsMoverTest(unittest.TestCase):

def test_directory_expectation_is_updated(self):

self._mover.move('origin/path', 'destination')

self.assertFalse('origin/path' in self._filesystem.read_text_file(self._port._absolute_path('TestExpectations')))

- self.assertTrue('crbug.com/42 [ Win ] destination [ Slow ]' in self._filesystem.read_text_file(self._port._absolute_path('TestExpectations')))

+ self.assertTrue('crbug.com/42 [ Win ] destination [ Crash ]' in self._filesystem.read_text_file(self._port._absolute_path('TestExpectations')))

def test_expectation_is_added_when_subdirectory_moved(self):

self._mover.move('origin/path', 'destination')