Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py

Issue 1491143003: Linter should enforce Tests marked Slow or WontFix aren't allowed in TestExpectations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 def __contains__(self, item): 97 def __contains__(self, item):
98 return item in self.tests 98 return item in self.tests
99 99
100 def __getitem__(self, item): 100 def __getitem__(self, item):
101 return self.tests[item] 101 return self.tests[item]
102 102
103 # 103 #
104 # These numbers may need to be updated whenever we add or delete tests. This inc ludes virtual tests. 104 # These numbers may need to be updated whenever we add or delete tests. This inc ludes virtual tests.
105 # 105 #
106 TOTAL_TESTS = 114 106 TOTAL_TESTS = 114
107 TOTAL_SKIPS = 29 107 TOTAL_SKIPS = 26
108 108 TOTAL_CRASHES = 80
109 UNEXPECTED_PASSES = 1 109 UNEXPECTED_PASSES = 1
110 UNEXPECTED_FAILURES = 26 110 UNEXPECTED_FAILURES = 26
111 111
112 def unit_test_list(): 112 def unit_test_list():
113 tests = TestList() 113 tests = TestList()
114 tests.add('failures/expected/crash.html', crash=True) 114 tests.add('failures/expected/crash.html', crash=True)
115 tests.add('failures/expected/exception.html', exception=True) 115 tests.add('failures/expected/exception.html', exception=True)
116 tests.add('failures/expected/device_failure.html', device_failure=True) 116 tests.add('failures/expected/device_failure.html', device_failure=True)
117 tests.add('failures/expected/timeout.html', timeout=True) 117 tests.add('failures/expected/timeout.html', timeout=True)
118 tests.add('failures/expected/leak.html', leak=True) 118 tests.add('failures/expected/leak.html', leak=True)
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 Bug(test) failures/expected/missing_check.html [ Missing Pass ] 294 Bug(test) failures/expected/missing_check.html [ Missing Pass ]
295 Bug(test) failures/expected/missing_image.html [ Missing Pass ] 295 Bug(test) failures/expected/missing_image.html [ Missing Pass ]
296 Bug(test) failures/expected/missing_audio.html [ Missing Pass ] 296 Bug(test) failures/expected/missing_audio.html [ Missing Pass ]
297 Bug(test) failures/expected/missing_text.html [ Missing Pass ] 297 Bug(test) failures/expected/missing_text.html [ Missing Pass ]
298 Bug(test) failures/expected/newlines_leading.html [ Failure ] 298 Bug(test) failures/expected/newlines_leading.html [ Failure ]
299 Bug(test) failures/expected/newlines_trailing.html [ Failure ] 299 Bug(test) failures/expected/newlines_trailing.html [ Failure ]
300 Bug(test) failures/expected/newlines_with_excess_CR.html [ Failure ] 300 Bug(test) failures/expected/newlines_with_excess_CR.html [ Failure ]
301 Bug(test) failures/expected/reftest.html [ Failure ] 301 Bug(test) failures/expected/reftest.html [ Failure ]
302 Bug(test) failures/expected/text.html [ Failure ] 302 Bug(test) failures/expected/text.html [ Failure ]
303 Bug(test) failures/expected/timeout.html [ Timeout ] 303 Bug(test) failures/expected/timeout.html [ Timeout ]
304 Bug(test) failures/expected/keyboard.html [ WontFix ] 304 Bug(test) failures/expected/keyboard.html [ Crash ]
305 Bug(test) failures/expected/exception.html [ WontFix ] 305 Bug(test) failures/expected/exception.html [ Crash ]
306 Bug(test) failures/expected/device_failure.html [ WontFix ] 306 Bug(test) failures/expected/device_failure.html [ Crash ]
307 Bug(test) failures/expected/leak.html [ Leak ] 307 Bug(test) failures/expected/leak.html [ Leak ]
308 Bug(test) failures/unexpected/pass.html [ Failure ] 308 Bug(test) failures/unexpected/pass.html [ Failure ]
309 Bug(test) passes/skipped/skip.html [ Skip ] 309 Bug(test) passes/skipped/skip.html [ Skip ]
310 Bug(test) passes/text.html [ Pass ] 310 Bug(test) passes/text.html [ Pass ]
311 """) 311 """)
312 312
313 filesystem.maybe_make_directory(LAYOUT_TEST_DIR + '/reftests/foo') 313 filesystem.maybe_make_directory(LAYOUT_TEST_DIR + '/reftests/foo')
314 filesystem.write_text_file(LAYOUT_TEST_DIR + '/reftests/foo/reftest.list', " "" 314 filesystem.write_text_file(LAYOUT_TEST_DIR + '/reftests/foo/reftest.list', " ""
315 == test.html test-ref.html 315 == test.html test-ref.html
316 316
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 else: 652 else:
653 image = test.actual_image 653 image = test.actual_image
654 return DriverOutput(actual_text, image, test.actual_checksum, audio, 654 return DriverOutput(actual_text, image, test.actual_checksum, audio,
655 crash=(crash or web_process_crash), crashed_process_name=crashed_pro cess_name, 655 crash=(crash or web_process_crash), crashed_process_name=crashed_pro cess_name,
656 crashed_pid=crashed_pid, crash_log=crash_log, 656 crashed_pid=crashed_pid, crash_log=crash_log,
657 test_time=time.time() - start_time, timeout=test.timeout, error=test .error, pid=self.pid, 657 test_time=time.time() - start_time, timeout=test.timeout, error=test .error, pid=self.pid,
658 leak=test.leak) 658 leak=test.leak)
659 659
660 def stop(self): 660 def stop(self):
661 self.started = False 661 self.started = False
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698