Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: content/browser/android/date_time_chooser_android.cc

Issue 1489453003: jni: Pass method parameters as JavaParamRef in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/date_time_chooser_android.cc
diff --git a/content/browser/android/date_time_chooser_android.cc b/content/browser/android/date_time_chooser_android.cc
index b555ef6d6b2e804035e2c510eed29f3c14ffda63..4f38402aa56648548563ec1426efacf1e498e200 100644
--- a/content/browser/android/date_time_chooser_android.cc
+++ b/content/browser/android/date_time_chooser_android.cc
@@ -19,6 +19,7 @@ using base::android::AttachCurrentThread;
using base::android::ConvertJavaStringToUTF16;
using base::android::ConvertUTF8ToJavaString;
using base::android::ConvertUTF16ToJavaString;
+using base::android::JavaRef;
namespace {
@@ -50,12 +51,13 @@ DateTimeChooserAndroid::~DateTimeChooserAndroid() {
}
void DateTimeChooserAndroid::ReplaceDateTime(JNIEnv* env,
- jobject,
+ const JavaRef<jobject>&,
Torne 2015/11/30 11:47:06 I'm using JavaRef instead of JavaParamRef in this
jdouble value) {
host_->Send(new ViewMsg_ReplaceDateTime(host_->GetRoutingID(), value));
}
-void DateTimeChooserAndroid::CancelDialog(JNIEnv* env, jobject) {
+void DateTimeChooserAndroid::CancelDialog(JNIEnv* env,
+ const JavaRef<jobject>&) {
host_->Send(new ViewMsg_CancelDateTimeDialog(host_->GetRoutingID()));
}
@@ -100,7 +102,7 @@ void DateTimeChooserAndroid::ShowDialog(
step,
suggestions_array.obj()));
if (j_date_time_chooser_.is_null())
- ReplaceDateTime(env, j_date_time_chooser_.obj(), dialog_value);
+ ReplaceDateTime(env, j_date_time_chooser_, dialog_value);
}
// ----------------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698