Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1489413006: Revert of Provide call counts for constructor calls, surface them as a vector IC. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Provide call counts for constructor calls, surface them as a vector IC. (patchset #4 id:60001 of https://codereview.chromium.org/1476413003/ ) Reason for revert: Seems to be (mostly) responsible for the most recent Speedometer regression, not 100% sure. Let's see what the bots have to say. Original issue's description: > Provide call counts for constructor calls, surface them as a vector IC. > > CallIC and CallConstructStub look so alike, at least in the feedback they gather even if the implementation differs...and CallIC has such a nice way of surfacing the feedback (CallICNexus), that there is a request to make CallConstructStub look analogous. Enter ConstructICStub. > > BUG= > > Committed: https://crrev.com/66d5a9df62da458a51e8c7ed1811dc9660f4f418 > Cr-Commit-Position: refs/heads/master@{#32452} TBR=mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/e89e08ca144693f522ddc46ffaf00d987515cc20 Cr-Commit-Position: refs/heads/master@{#32599}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -367 lines) Patch
M src/arm/code-stubs-arm.cc View 5 chunks +3 lines, -18 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 5 chunks +3 lines, -23 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ast/ast.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/code-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/code-stubs.h View 2 chunks +8 lines, -11 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 4 chunks +62 lines, -54 lines 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +3 lines, -17 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ic/ic.h View 2 chunks +2 lines, -13 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/log.h View 1 chunk +56 lines, -56 lines 0 comments Download
M src/log.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 5 chunks +3 lines, -20 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 5 chunks +3 lines, -21 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/type-feedback-vector.h View 6 chunks +4 lines, -23 lines 0 comments Download
M src/type-feedback-vector.cc View 4 chunks +0 lines, -24 lines 0 comments Download
M src/type-info.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 6 chunks +3 lines, -14 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
Created Revert of Provide call counts for constructor calls, surface them as a vector IC.
5 years ago (2015-12-04 07:33:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489413006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489413006/1
5 years ago (2015-12-04 07:33:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 07:33:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e89e08ca144693f522ddc46ffaf00d987515cc20 Cr-Commit-Position: refs/heads/master@{#32599}
5 years ago (2015-12-04 07:34:40 UTC) #5
mvstanton
5 years ago (2015-12-04 09:23:14 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698