src/full-codegen/ia32/full-codegen-ia32.cc - Issue 1489413006: Revert of Provide call counts for constructor calls, surface them as a vector IC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1489413006: Revert of Provide call counts for constructor calls, surface them as a vector IC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 9057fc4cd824690c755c96a7901bfc9f91693cd1..66ada7986ec6a794e1ebfa3cf2b80b7778bc70b7 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -2909,8 +2909,8 @@

__ EmitLoadTypeFeedbackVector(ebx);

__ mov(edx, Immediate(SmiFromSlot(expr->CallNewFeedbackSlot())));

- Handle<Code> code = CodeFactory::ConstructIC(isolate()).code();

- __ call(code, RelocInfo::CODE_TARGET);

+ CallConstructStub stub(isolate());

+ __ call(stub.GetCode(), RelocInfo::CODE_TARGET);

PrepareForBailoutForId(expr->ReturnId(), TOS_REG);

// Restore context register.

__ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));

« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »