V8 Buildbot: Properly set revision property for triggered tryjobs.

V8 Buildbot: Properly set revision property for triggered tryjobs.

BUG=chromium:561530
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297825

[Michael Achenbach, 2015-12-02 17:07:30]

Description was changed from

==========
V8 Buildbot: Properly set revision property for triggered tryjobs.

BUG=
==========

to

==========
V8 Buildbot: Properly set revision property for triggered tryjobs.

BUG=chromium:561530
==========

[Michael Achenbach, 2015-12-02 17:07:30]

machenbach@chromium.org changed reviewers:
+ tandrii@chromium.org

[Michael Achenbach, 2015-12-02 17:09:01]

PTAL

[tandrii(chromium), 2015-12-02 17:13:04]

https://codereview.chromium.org/1489293003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/v8/api.py (right):

https://codereview.chromium.org/1489293003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/v8/api.py:1021: # testers to match the revision
field.
this is confusing because it's in the "else" block ===== not a tryserver. And
the revision seems set in either case - above and below.

[Michael Achenbach, 2015-12-02 17:36:00]

PTAL

https://codereview.chromium.org/1489293003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/v8/api.py (right):

https://codereview.chromium.org/1489293003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/v8/api.py:1021: # testers to match the revision
field.
On 2015/12/02 17:13:04, tandrii(chromium) wrote:
> this is confusing because it's in the "else" block ===== not a tryserver. And
> the revision seems set in either case - above and below.

Improved my comments.

[tandrii(chromium), 2015-12-02 17:39:46]

lgtm

https://codereview.chromium.org/1489293003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/v8/api.py (right):

https://codereview.chromium.org/1489293003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/v8/api.py:1021: # testers to match the revision
field.
On 2015/12/02 17:36:00, Michael Achenbach (slow) wrote:
> On 2015/12/02 17:13:04, tandrii(chromium) wrote:
> > this is confusing because it's in the "else" block ===== not a tryserver.
And
> > the revision seems set in either case - above and below.
> 
> Improved my comments.

yep, very readable now.

[Michael Achenbach, 2015-12-03 08:03:55]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-12-03 08:04:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1489293003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1489293003/20001

[commit-bot: I haz the power, 2015-12-03 08:05:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 08:06:00]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[Michael Achenbach, 2015-12-03 08:13:09]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2015-12-03 08:13:09]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1489293003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2015-12-03 08:13:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1489293003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1489293003/40001

[commit-bot: I haz the power, 2015-12-03 08:15:33]

Description was changed from

==========
V8 Buildbot: Properly set revision property for triggered tryjobs.

BUG=chromium:561530
==========

to

==========
V8 Buildbot: Properly set revision property for triggered tryjobs.

BUG=chromium:561530

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297825
==========

[commit-bot: I haz the power, 2015-12-03 08:15:33]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297825