Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: scripts/slave/recipe_modules/v8/api.py

Issue 1489293003: V8 Buildbot: Properly set revision property for triggered tryjobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/v8/api.py
diff --git a/scripts/slave/recipe_modules/v8/api.py b/scripts/slave/recipe_modules/v8/api.py
index 051de3cd9c690da6c9e20515f9d1d5b281b32e5c..4545c64eb48e4b893b1291fba3db9304e08d5f93 100644
--- a/scripts/slave/recipe_modules/v8/api.py
+++ b/scripts/slave/recipe_modules/v8/api.py
@@ -1003,7 +1003,6 @@ class V8Api(recipe_api.RecipeApi):
triggers = self.bot_config.get('triggers')
if triggers:
properties = {
- 'revision': self.revision,
'parent_got_revision': self.revision,
'parent_got_revision_cp': self.revision_cp,
}
@@ -1017,8 +1016,15 @@ class V8Api(recipe_api.RecipeApi):
patchset=str(self.m.properties['patchset']),
reason=str(self.m.properties['reason']),
requester=str(self.m.properties['requester']),
+ # On tryservers, set revision to the same as on the current bot,
+ # as CQ expects builders and testers to match the revision field.
+ revision=str(self.m.properties.get('revision', 'HEAD')),
rietveld=str(self.m.properties['rietveld']),
)
+ else:
+ # On non-tryservers, we can set the revision to whatever the
+ # triggering builder checked out.
+ properties['revision'] = self.revision
# TODO(machenbach): Also set meaningful buildbucket tags of triggering
# parent.
« no previous file with comments | « no previous file | scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698