V8 Buildbot: Properly set revision property for triggered tryjobs.

scripts/slave/recipe_modules/v8/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import collections
 import datetime
 import math
 import re
 import urllib
@@ skipping 985 matching lines @@
       'merge perf results' + kwargs.pop('suffix', ''),
       self.resource('merge_perf_result_maps.py'),
       [self.m.json.input(results_file_map)],
       stdout=self.m.json.output(),
     ).stdout
 
   def maybe_trigger(self, **additional_properties):
     triggers = self.bot_config.get('triggers')
     if triggers:
       properties = {
-        'revision': self.revision,
         'parent_got_revision': self.revision,
         'parent_got_revision_cp': self.revision_cp,
       }
       if self.m.tryserver.is_tryserver:
         properties.update(
           issue=self.m.properties['issue'],
           patch_project=str(self.m.properties['patch_project']),
           patch_storage=str(self.m.properties['patch_storage']),
           patchset=str(self.m.properties['patchset']),
           requester=str(self.m.properties['requester']),
+          revision=str(self.m.properties.get('revision', 'HEAD')),
           rietveld=str(self.m.properties['rietveld']),
         )
+      else:
+        # Don't set revision on tryservers, as CQ expects builders and
+        # testers to match the revision field.

[tandrii(chromium), 2015/12/02 17:13:04]

this is confusing because it's in the "else" block ===== not a tryserver. And
the revision seems set in either case - above and below.

[Michael Achenbach, 2015/12/02 17:36:00]

Improved my comments.

[tandrii(chromium), 2015/12/02 17:39:46]

yep, very readable now.

+        properties['revision'] = self.revision
       swarm_hashes = self.m.isolate.isolated_tests
       if swarm_hashes:
         properties['swarm_hashes'] = swarm_hashes
       properties.update(**additional_properties)
       self.m.trigger(*[{
         'builder_name': builder_name,
         'properties': properties,
       } for builder_name in triggers])
 
   def get_change_range(self):
@@ skipping 115 matching lines @@
   def report_culprits(self, culprit_range):
     assert culprit_range
     if len(culprit_range) > 1:
       text = 'Suspecting multiple commits'
     else:
       text = 'Suspecting %s' % culprit_range[0][:8]
 
     step_result = self.m.step(text, cmd=None)
     for culprit in culprit_range:
       step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit