Misc fixes for gn builds with VS 2015

Misc fixes for gn builds with VS 2015

These changes are enough to get gn_all building with VS 2015 in
32-bit gn builds. The changes are mostly to fix warnings about
truncation from size_t to smaller types.

One fix is to avoid illegal #defines, already fixed in the GYP builds.

Warning 4267 is disabled in the main BUILD.gn file because many of the
4244 warnings that VC++ 2013 emits are now emitted as 4267, so we need
to disable 4267 everywhere that 4244 is disabled. Fixing the code is
best done as a separate task.

The code fixes are to avoid truncations, mostly by using more
appropriate types.

BUG=440500
Committed: https://crrev.com/c8e9e0d00bc2ba692ee4e61ae728a50e911513c1
Cr-Commit-Position: refs/heads/master@{#362858}

[brucedawson, 2015-12-01 01:36:27]

Description was changed from

==========
Fix misc size_t truncations for 64-bit VS 2015

These changes are enough to get the libexif, leveldatabase, printing,
gpu, and google_apis portions of Chromium building with VS 2015 in
64-bit gn builds. The changes are all to fix warnings about truncation
from size_t to smaller types.

R=brettw@chromium.org
BUG=440500
==========

to

==========
Misc fixes for gn builds with 64-bit VS 2015

These changes are enough to get the libexif, leveldatabase, printing,
gpu, and google_apis portions of Chromium building with VS 2015 in
64-bit gn builds. The changes are mostly to fix warnings about
truncation from size_t to smaller types.

One fix is to avoid illegal #defines, already fixed in the GYP builds.

R=brettw@chromium.org
BUG=440500
==========

[brucedawson, 2015-12-01 01:39:40]

PTAL.

There's five more files in chrome/components with similar fixes if you want that
(simple) CL as well...

[brucedawson, 2015-12-01 01:49:10]

On 2015/12/01 01:39:40, brucedawson wrote:
> PTAL.
> 
> There's five more files in chrome/components with similar fixes if you want
that
> (simple) CL as well...

Oh wait - one of the try jobs failed and the change needs fixing.

[brucedawson, 2015-12-01 18:56:03]

PTAL. The try bot failure has been fixed. The current try bot failures are
spurious/unrelated and should not affect this change.

[brucedawson, 2015-12-02 01:01:52]

Description was changed from

==========
Misc fixes for gn builds with 64-bit VS 2015

These changes are enough to get the libexif, leveldatabase, printing,
gpu, and google_apis portions of Chromium building with VS 2015 in
64-bit gn builds. The changes are mostly to fix warnings about
truncation from size_t to smaller types.

One fix is to avoid illegal #defines, already fixed in the GYP builds.

R=brettw@chromium.org
BUG=440500
==========

to

==========
Misc fixes for gn builds with VS 2015

These changes are enough to get the libexif, leveldatabase, printing,
gpu, and google_apis portions of Chromium building with VS 2015 in
gn builds. The changes are mostly to fix warnings about truncation
from size_t to smaller types.

One fix is to avoid illegal #defines, already fixed in the GYP builds.

R=brettw@chromium.org
BUG=440500
==========

[brucedawson, 2015-12-02 18:24:12]

Description was changed from

==========
Misc fixes for gn builds with VS 2015

These changes are enough to get the libexif, leveldatabase, printing,
gpu, and google_apis portions of Chromium building with VS 2015 in
gn builds. The changes are mostly to fix warnings about truncation
from size_t to smaller types.

One fix is to avoid illegal #defines, already fixed in the GYP builds.

R=brettw@chromium.org
BUG=440500
==========

to

==========
Misc fixes for gn builds with VS 2015

These changes are enough to get gn_all building with VS 2015 in
32-bit gn builds. The changes are mostly to fix warnings about
truncation from size_t to smaller types.

One fix is to avoid illegal #defines, already fixed in the GYP builds.

Warning 4267 is disabled in the main BUILD.gn file because many of the
4244 warnings that VC++ 2013 emits are now emitted as 4267, so we need
to disable 4267 everywhere that 4244 is disabled. Fixing the code is
best done as a separate task.

The code fixes are to avoid truncations, mostly by using more
appropriate types.

R=brettw@chromium.org
BUG=440500
==========

[brucedawson, 2015-12-02 18:24:12]

brucedawson@chromium.org changed reviewers:
+ dpranke@chromium.org

[brucedawson, 2015-12-02 18:24:23]

Description was changed from

==========
Misc fixes for gn builds with VS 2015

These changes are enough to get gn_all building with VS 2015 in
32-bit gn builds. The changes are mostly to fix warnings about
truncation from size_t to smaller types.

One fix is to avoid illegal #defines, already fixed in the GYP builds.

Warning 4267 is disabled in the main BUILD.gn file because many of the
4244 warnings that VC++ 2013 emits are now emitted as 4267, so we need
to disable 4267 everywhere that 4244 is disabled. Fixing the code is
best done as a separate task.

The code fixes are to avoid truncations, mostly by using more
appropriate types.

R=brettw@chromium.org
BUG=440500
==========

to

==========
Misc fixes for gn builds with VS 2015

These changes are enough to get gn_all building with VS 2015 in
32-bit gn builds. The changes are mostly to fix warnings about
truncation from size_t to smaller types.

One fix is to avoid illegal #defines, already fixed in the GYP builds.

Warning 4267 is disabled in the main BUILD.gn file because many of the
4244 warnings that VC++ 2013 emits are now emitted as 4267, so we need
to disable 4267 everywhere that 4244 is disabled. Fixing the code is
best done as a separate task.

The code fixes are to avoid truncations, mostly by using more
appropriate types.

BUG=440500
==========

[brucedawson, 2015-12-02 18:26:17]

PTAL. This is enough to get 32-bit gn_all building with VC++ 2015 - disabling
4267 was crucial to doing this sanely.

The code changes are now all optional, but I think they are the right thing to
do and I'd already made the changes.

[brettw, 2015-12-02 18:33:59]

https://codereview.chromium.org/1488933002/diff/40001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1488933002/diff/40001/build/config/compiler/B...
build/config/compiler/BUILD.gn:744: "/wd4267",  # Conversion: possible loss of
data.
We don't want to add this globally. jschuh spent a long time removing this
global disable previuosly, and individual targets add the
no_size_t_to_int_warning if they haven't been fixed yet.

[brucedawson, 2015-12-02 18:45:54]

On 2015/12/02 18:33:59, brettw wrote:
>
https://codereview.chromium.org/1488933002/diff/40001/build/config/compiler/B...
> File build/config/compiler/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1488933002/diff/40001/build/config/compiler/B...
> build/config/compiler/BUILD.gn:744: "/wd4267",  # Conversion: possible loss of
> data.
> We don't want to add this globally. jschuh spent a long time removing this
> global disable previuosly, and individual targets add the
> no_size_t_to_int_warning if they haven't been fixed yet.

Yeah, I resisted for a long time, but we already globally disable warning 4244
and most or all of those 4244 warnings get emitted as 4267 in VC++ 2015.
Therefore, to do a sane migration to VC++ 2015 we need to disable 4267, at least
for a while. Or we need to enable 4244 and fix what pops up. This is an example
of code that triggers 4244 in 2013 and 4267 in 2015:

short TruncationTest(size_t x) { return x; }

I had the VC++ builds working without disabling 4267 but then ~ten new warnings
popped up in one day, which is not sustainable until we get that checked on the
try-bots.

I certainly could disable 4267 for VC++ 2015 only, and once we switch it would
be easy to revert that and fix whatever has accumulated. That would avoid any
backsliding in the interim.

[brettw, 2015-12-02 18:52:08]

On 2015/12/02 18:45:54, brucedawson wrote:
> On 2015/12/02 18:33:59, brettw wrote:
> >
>
https://codereview.chromium.org/1488933002/diff/40001/build/config/compiler/B...
> > File build/config/compiler/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/1488933002/diff/40001/build/config/compiler/B...
> > build/config/compiler/BUILD.gn:744: "/wd4267",  # Conversion: possible loss
of
> > data.
> > We don't want to add this globally. jschuh spent a long time removing this
> > global disable previuosly, and individual targets add the
> > no_size_t_to_int_warning if they haven't been fixed yet.
> 
> Yeah, I resisted for a long time, but we already globally disable warning 4244
> and most or all of those 4244 warnings get emitted as 4267 in VC++ 2015.
> Therefore, to do a sane migration to VC++ 2015 we need to disable 4267, at
least
> for a while. Or we need to enable 4244 and fix what pops up. This is an
example
> of code that triggers 4244 in 2013 and 4267 in 2015:
> 
> short TruncationTest(size_t x) { return x; }
> 
> I had the VC++ builds working without disabling 4267 but then ~ten new
warnings
> popped up in one day, which is not sustainable until we get that checked on
the
> try-bots.
> 
> I certainly could disable 4267 for VC++ 2015 only, and once we switch it would
> be easy to revert that and fix whatever has accumulated. That would avoid any
> backsliding in the interim.

You should talk to Justin if you want to do this.

[brucedawson, 2015-12-02 18:56:02]

On 2015/12/02 18:52:08, brettw wrote:
> On 2015/12/02 18:45:54, brucedawson wrote:
> > On 2015/12/02 18:33:59, brettw wrote:
> > >
> >
>
https://codereview.chromium.org/1488933002/diff/40001/build/config/compiler/B...
> > > File build/config/compiler/BUILD.gn (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1488933002/diff/40001/build/config/compiler/B...
> > > build/config/compiler/BUILD.gn:744: "/wd4267",  # Conversion: possible
loss
> of
> > > data.
> > > We don't want to add this globally. jschuh spent a long time removing this
> > > global disable previuosly, and individual targets add the
> > > no_size_t_to_int_warning if they haven't been fixed yet.
> > 
> > Yeah, I resisted for a long time, but we already globally disable warning
4244
> > and most or all of those 4244 warnings get emitted as 4267 in VC++ 2015.
> > Therefore, to do a sane migration to VC++ 2015 we need to disable 4267, at
> least
> > for a while. Or we need to enable 4244 and fix what pops up. This is an
> example
> > of code that triggers 4244 in 2013 and 4267 in 2015:
> > 
> > short TruncationTest(size_t x) { return x; }
> > 
> > I had the VC++ builds working without disabling 4267 but then ~ten new
> warnings
> > popped up in one day, which is not sustainable until we get that checked on
> the
> > try-bots.
> > 
> > I certainly could disable 4267 for VC++ 2015 only, and once we switch it
would
> > be easy to revert that and fix whatever has accumulated. That would avoid
any
> > backsliding in the interim.
> 
> You should talk to Justin if you want to do this.

I'll make the warning change VC++ 2015 only and then talk to Justin.

[jschuh, 2015-12-02 20:04:20]

How many new targets are now hitting 4267 due to the reclassification in 2015?
Other than that, I'm fine landing this as a 2015 only exclusion and narrowing it
to specific targets prior to or in conjunction with making the switch.

[brucedawson, 2015-12-02 20:26:22]

On 2015/12/02 20:04:20, jschuh (very slow) wrote:
> How many new targets are now hitting 4267 due to the reclassification in 2015?
> Other than that, I'm fine landing this as a 2015 only exclusion and narrowing
it
> to specific targets prior to or in conjunction with making the switch.

You can see one batch of warning fixes in CL
https://codereview.chromium.org/1485023003/. Together with some already landed
CLs that was, briefly, enough to get things building with gn. Then new warnings
showed up. So, re-disabling C4267 after the switch will be easy. I just don't
want new breaks every time I do a pull.

There are a half-dozen new warnings. The risk in my fixing them is that
eventually I will be casting away a real bug because I don't have the context of
the author, or the time to do it right.

[jschuh, 2015-12-02 21:08:25]

On 2015/12/02 20:26:22, brucedawson wrote:
> On 2015/12/02 20:04:20, jschuh (very slow) wrote:
> > How many new targets are now hitting 4267 due to the reclassification in
2015?
> > Other than that, I'm fine landing this as a 2015 only exclusion and
narrowing
> it
> > to specific targets prior to or in conjunction with making the switch.
> 
> You can see one batch of warning fixes in CL
> https://codereview.chromium.org/1485023003/. Together with some already landed
> CLs that was, briefly, enough to get things building with gn. Then new
warnings
> showed up. So, re-disabling C4267 after the switch will be easy. I just don't
> want new breaks every time I do a pull.
> 
> There are a half-dozen new warnings. The risk in my fixing them is that
> eventually I will be casting away a real bug because I don't have the context
of
> the author, or the time to do it right.

Yeah, I'm familiar with this dance. Lgtm, and we'll make it more granular in a
follow-up where you can prevent regressions.

[brettw, 2015-12-03 00:21:45]

lgtm

[brucedawson, 2015-12-03 00:54:35]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2015-12-03 00:55:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488933002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488933002/60001

[commit-bot: I haz the power, 2015-12-03 01:54:34]

Description was changed from

==========
Misc fixes for gn builds with VS 2015

These changes are enough to get gn_all building with VS 2015 in
32-bit gn builds. The changes are mostly to fix warnings about
truncation from size_t to smaller types.

One fix is to avoid illegal #defines, already fixed in the GYP builds.

Warning 4267 is disabled in the main BUILD.gn file because many of the
4244 warnings that VC++ 2013 emits are now emitted as 4267, so we need
to disable 4267 everywhere that 4244 is disabled. Fixing the code is
best done as a separate task.

The code fixes are to avoid truncations, mostly by using more
appropriate types.

BUG=440500
==========

to

==========
Misc fixes for gn builds with VS 2015

These changes are enough to get gn_all building with VS 2015 in
32-bit gn builds. The changes are mostly to fix warnings about
truncation from size_t to smaller types.

One fix is to avoid illegal #defines, already fixed in the GYP builds.

Warning 4267 is disabled in the main BUILD.gn file because many of the
4244 warnings that VC++ 2013 emits are now emitted as 4267, so we need
to disable 4267 everywhere that 4244 is disabled. Fixing the code is
best done as a separate task.

The code fixes are to avoid truncations, mostly by using more
appropriate types.

BUG=440500
==========

[commit-bot: I haz the power, 2015-12-03 01:54:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-03 01:55:42]

Description was changed from

==========
Misc fixes for gn builds with VS 2015

These changes are enough to get gn_all building with VS 2015 in
32-bit gn builds. The changes are mostly to fix warnings about
truncation from size_t to smaller types.

One fix is to avoid illegal #defines, already fixed in the GYP builds.

Warning 4267 is disabled in the main BUILD.gn file because many of the
4244 warnings that VC++ 2013 emits are now emitted as 4267, so we need
to disable 4267 everywhere that 4244 is disabled. Fixing the code is
best done as a separate task.

The code fixes are to avoid truncations, mostly by using more
appropriate types.

BUG=440500
==========

to

==========
Misc fixes for gn builds with VS 2015

These changes are enough to get gn_all building with VS 2015 in
32-bit gn builds. The changes are mostly to fix warnings about
truncation from size_t to smaller types.

One fix is to avoid illegal #defines, already fixed in the GYP builds.

Warning 4267 is disabled in the main BUILD.gn file because many of the
4244 warnings that VC++ 2013 emits are now emitted as 4267, so we need
to disable 4267 everywhere that 4244 is disabled. Fixing the code is
best done as a separate task.

The code fixes are to avoid truncations, mostly by using more
appropriate types.

BUG=440500

Committed: https://crrev.com/c8e9e0d00bc2ba692ee4e61ae728a50e911513c1
Cr-Commit-Position: refs/heads/master@{#362858}
==========

[commit-bot: I haz the power, 2015-12-03 01:55:43]

Patchset 4 (id:??) landed as
https://crrev.com/c8e9e0d00bc2ba692ee4e61ae728a50e911513c1
Cr-Commit-Position: refs/heads/master@{#362858}