Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2216)

Unified Diff: google_apis/gcm/base/mcs_util_unittest.cc

Issue 1488933002: Misc fixes for gn builds with VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable C4267 for VC++ 2015 builds only Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | gpu/command_buffer/client/query_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/base/mcs_util_unittest.cc
diff --git a/google_apis/gcm/base/mcs_util_unittest.cc b/google_apis/gcm/base/mcs_util_unittest.cc
index d51f5a07f7851ef56182b31ccbe80fee69507834..34d482d133e6dace622b8013431beea7b4851833 100644
--- a/google_apis/gcm/base/mcs_util_unittest.cc
+++ b/google_apis/gcm/base/mcs_util_unittest.cc
@@ -31,12 +31,12 @@ TEST(MCSUtilTest, BuildLoginRequest) {
// Test building a protobuf and extracting the tag from a protobuf.
TEST(MCSUtilTest, ProtobufToTag) {
- for (size_t i = 0; i < kNumProtoTypes; ++i) {
+ for (uint8 i = 0; i < kNumProtoTypes; ++i) {
scoped_ptr<google::protobuf::MessageLite> protobuf =
BuildProtobufFromTag(i);
if (!protobuf.get()) // Not all tags have protobuf definitions.
continue;
- ASSERT_EQ((int)i, GetMCSProtoTag(*protobuf)) << "Type " << i;
+ ASSERT_EQ(i, GetMCSProtoTag(*protobuf)) << "Type " << i;
}
}
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | gpu/command_buffer/client/query_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698