Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/libexif/BUILD.gn

Issue 1488933002: Misc fixes for gn builds with VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable C4267 for VC++ 2015 builds only Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/leveldatabase/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libexif/BUILD.gn
diff --git a/third_party/libexif/BUILD.gn b/third_party/libexif/BUILD.gn
index 3f88f1c93edfdc992403f7d650b8a0813af6bc23..ea9ca90ce2a1ac357967938b4ee50c09ee8dcbb8 100644
--- a/third_party/libexif/BUILD.gn
+++ b/third_party/libexif/BUILD.gn
@@ -57,11 +57,16 @@ if (!is_linux || is_chromeos) {
# TODO(GYP): Additional options for non-Windows platforms.
if (is_win) {
- defines = [
- # This seems like a hack, but this is what WebKit Win does.
- "snprintf=_snprintf",
- "inline=__inline",
- ]
+ import("//build/config/win/visual_studio_version.gni")
+
+ if (visual_studio_version == "2013" || visual_studio_version == "2013e") {
+ defines = [
+ # This seems like a hack, but this is what WebKit Win does.
+ # VS 2015 supports these natively so they cannot be #defines.
+ "snprintf=_snprintf",
+ "inline=__inline",
+ ]
+ }
ldflags = [ "/DEF:" + rebase_path("libexif.def") ]
« no previous file with comments | « third_party/leveldatabase/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698