content/renderer/accessibility/blink_ax_tree_source.cc - Issue 1488893002: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 1488893002: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test for menu checkboxes and removed indeterminate state. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/accessibility/browser_accessibility_win.cc ('K') | « content/renderer/accessibility/blink_ax_enum_conversion.cc ('k') | content/test/data/accessibility/html/input-checkbox.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index 57158f61a95c9464e4fbd95a12f1edcdfed604b8..0ab082f02b2c447a5ea5e4fdd00ac92983449619 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -365,7 +365,7 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

if (src.isAriaReadOnly())

dst->AddBoolAttribute(ui::AX_ATTR_ARIA_READONLY, true);

if (src.isButtonStateMixed())

- dst->AddBoolAttribute(ui::AX_ATTR_BUTTON_MIXED, true);

+ dst->AddBoolAttribute(ui::AX_ATTR_CHECKBOX_MIXED, true);

if (src.canSetValueAttribute())

dst->AddBoolAttribute(ui::AX_ATTR_CAN_SET_VALUE, true);

if (src.hasComputedStyle()) {