content/renderer/accessibility/blink_ax_enum_conversion.cc - Issue 1488893002: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_enum_conversion.cc

Issue 1488893002: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test for menu checkboxes and removed indeterminate state. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/accessibility/browser_accessibility_win.cc ('K') | « content/browser/accessibility/browser_accessibility_win.cc ('k') | content/renderer/accessibility/blink_ax_tree_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/blink_ax_enum_conversion.cc

diff --git a/content/renderer/accessibility/blink_ax_enum_conversion.cc b/content/renderer/accessibility/blink_ax_enum_conversion.cc

index 0322f595601d95eb94d9f494a350a54866f1305a..72c8779b176a58d2bc5838cd2d08d431b396947d 100644

--- a/content/renderer/accessibility/blink_ax_enum_conversion.cc

+++ b/content/renderer/accessibility/blink_ax_enum_conversion.cc

@@ -34,9 +34,6 @@ uint32 AXStateFromBlink(const blink::WebAXObject& o) {

if (o.isHovered())

state |= (1 << ui::AX_STATE_HOVERED);

- if (o.isIndeterminate())

- state |= (1 << ui::AX_STATE_INDETERMINATE);

if (!o.isVisible())

state |= (1 << ui::AX_STATE_INVISIBLE);