content/browser/accessibility/browser_accessibility_win.cc - Issue 1488893002: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 1488893002: Stops using SYSTEM_STATE_INDETERMINATE as it makes radio buttons appear to have a mixed state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test for menu checkboxes and removed indeterminate state. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/accessibility/browser_accessibility_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc

index 0ee584e861790897901a6d4783229753f7c6ff7e..5ed605c284160bb34401bd46cd04d610fce57612 100644

--- a/content/browser/accessibility/browser_accessibility_win.cc

+++ b/content/browser/accessibility/browser_accessibility_win.cc

@@ -4160,8 +4160,6 @@ void BrowserAccessibilityWin::InitRoleAndState() {

ia_state |= STATE_SYSTEM_FOCUSABLE;

if (HasState(ui::AX_STATE_HASPOPUP))

ia_state |= STATE_SYSTEM_HASPOPUP;

- if (HasState(ui::AX_STATE_INDETERMINATE))

- ia_state |= STATE_SYSTEM_INDETERMINATE;

if (HasIntAttribute(ui::AX_ATTR_INVALID_STATE) &&

GetIntAttribute(ui::AX_ATTR_INVALID_STATE) != ui::AX_INVALID_STATE_FALSE)

ia2_state |= IA2_STATE_INVALID_ENTRY;

@@ -4210,7 +4208,7 @@ void BrowserAccessibilityWin::InitRoleAndState() {

if (IsEditableText())

ia2_state |= IA2_STATE_EDITABLE;

- if (GetBoolAttribute(ui::AX_ATTR_BUTTON_MIXED))

+ if (GetBoolAttribute(ui::AX_ATTR_CHECKBOX_MIXED))

dmazzoni 2015/12/01 21:57:32 Hmmm, by changing BUTTON_MIXED to CHECKBOX_MIXED,

ia_state |= STATE_SYSTEM_MIXED;

if (GetBoolAttribute(ui::AX_ATTR_CAN_SET_VALUE))

« no previous file with comments | « chrome/common/extensions/api/automation.idl ('k') | content/renderer/accessibility/blink_ax_enum_conversion.cc » ('j') | no next file with comments »