Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1488493003: [css-grid] refactoring of layout tests (Closed)

Created:
5 years ago by jfernandez
Modified:
4 years, 11 months ago
Reviewers:
svillar, Manuel Rego
CC:
chromium-reviews, blink-reviews, svillar, Manuel Rego
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] refactoring of layout tests In order to manage the css values and properties prefixes using by the different browsers, I've made several changes to reuse some css keywords and style files already defined in other folders. No need for additional tests since there is no functional change. Committed: https://crrev.com/1314b8fc0bc46b2e7f05095ecd35d34147b20bed Cr-Commit-Position: refs/heads/master@{#370840}

Patch Set 1 #

Total comments: 22

Patch Set 2 : Patch rebased and refactoring of alignment css rules. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+847 lines, -1226 lines) Patch
M third_party/WebKit/LayoutTests/fast/css-grid-layout/calc-resolution-grid-item.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-and-intrinsic-sizes.html View 3 chunks +6 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-and-intrinsic-sizes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align.html View 18 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-margin-border-padding.html View 1 21 chunks +51 lines, -58 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-lr.html View 1 21 chunks +51 lines, -57 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-rl.html View 1 21 chunks +51 lines, -57 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-overflow.html View 1 11 chunks +10 lines, -97 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-stretch.html View 1 19 chunks +24 lines, -89 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set.html View 2 chunks +25 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple.html View 2 chunks +23 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-container-margin-border-padding-scrollbar.html View 2 chunks +18 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html View 2 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-content-alignment-and-self-alignment.html View 1 18 chunks +49 lines, -79 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-content-alignment-overflow.html View 1 10 chunks +9 lines, -39 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-content-alignment-with-span.html View 1 10 chunks +9 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr.html View 1 10 chunks +9 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl.html View 1 10 chunks +9 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint.html View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-change-rows-repaint.html View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set.html View 2 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html View 2 chunks +32 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-and-alignment.html View 1 11 chunks +16 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment.html View 1 11 chunks +10 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-lr.html View 1 11 chunks +10 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-rl.html View 1 11 chunks +10 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-and-stretch.html View 8 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-auto-sized-align-justify-margin-border-padding.html View 1 21 chunks +52 lines, -92 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-border-overflow-paint.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-change-column-repaint.html View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-margin-auto-columns-rows.html View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-margin-auto-columns-rows-horiz-bt.html View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-margin-auto-columns-rows-vert-lr.html View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-margin-auto-columns-rows-vert-rl.html View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-order-paint-order.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-overflow-paint.html View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-stretch-with-margins-borders-padding.html View 14 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-stretch-with-margins-borders-padding-vertical-lr.html View 14 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-stretch-with-margins-borders-padding-vertical-rl.html View 14 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-z-index-change-repaint.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-z-index-stacking-context.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-z-index-stacking-context-expected.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change.html View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-justify-content-distribution.html View 1 2 chunks +1 line, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-justify-content-vertical-lr.html View 1 2 chunks +1 line, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-justify-content-vertical-rl.html View 1 2 chunks +1 line, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/justify-self-cell.html View 1 11 chunks +12 lines, -59 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/min-width-height-auto-and-margins.html View 4 chunks +14 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-fixed-logical-height-only.html View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-fixed-logical-width-only.html View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-columns.html View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-rows.html View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html View 2 chunks +19 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size.html View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html View 2 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html View 9 chunks +13 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/place-cell-by-index.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid.css View 2 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-alignment.css View 1 4 chunks +109 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/scrolled-grid-painting.html View 5 chunks +9 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/scrolled-grid-painting-overflow.html View 3 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
jfernandez
5 years ago (2015-12-01 14:25:34 UTC) #4
Manuel Rego
Non-owner LGTM. Really nice patch, thanks for the effort. Just a few comments inline. https://codereview.chromium.org/1488493003/diff/1/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html ...
5 years ago (2015-12-02 09:31:02 UTC) #5
jfernandez
Thanks for the review. See my comments inline. https://codereview.chromium.org/1488493003/diff/1/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html File third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html (right): https://codereview.chromium.org/1488493003/diff/1/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html#newcode12 third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html:12: } ...
5 years ago (2015-12-03 15:06:11 UTC) #6
Manuel Rego
https://codereview.chromium.org/1488493003/diff/1/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html File third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html (right): https://codereview.chromium.org/1488493003/diff/1/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html#newcode67 third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html:67: <div class="container"> On 2015/12/03 15:06:11, jfernandez wrote: > On ...
5 years ago (2015-12-04 13:12:43 UTC) #7
svillar
lgtm. Awesome job. https://codereview.chromium.org/1488493003/diff/1/third_party/WebKit/LayoutTests/fast/css-grid-layout/calc-resolution-grid-item.html File third_party/WebKit/LayoutTests/fast/css-grid-layout/calc-resolution-grid-item.html (right): https://codereview.chromium.org/1488493003/diff/1/third_party/WebKit/LayoutTests/fast/css-grid-layout/calc-resolution-grid-item.html#newcode28 third_party/WebKit/LayoutTests/fast/css-grid-layout/calc-resolution-grid-item.html:28: height: calc(70% + 30%); I don't ...
5 years ago (2015-12-04 13:18:31 UTC) #8
svillar
What happened with this?
4 years, 11 months ago (2016-01-19 12:16:14 UTC) #9
jfernandez
On 2016/01/19 12:16:14, svillar wrote: > What happened with this? I forgot to land it, ...
4 years, 11 months ago (2016-01-19 12:39:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1488493003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1488493003/20001
4 years, 11 months ago (2016-01-21 22:59:58 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 00:07:51 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 00:08:55 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1314b8fc0bc46b2e7f05095ecd35d34147b20bed
Cr-Commit-Position: refs/heads/master@{#370840}

Powered by Google App Engine
This is Rietveld 408576698