Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-fixed-logical-height-only.html

Issue 1488493003: [css-grid] refactoring of layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch rebased and refactoring of alignment css rules. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-fixed-logical-height-only.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-fixed-logical-height-only.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-fixed-logical-height-only.html
index 07e62d4c5d3d53882e6ec075b7a99e0d677a55df..12ddd5033477d5382bef5941968bb4b697db6686 100644
--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-fixed-logical-height-only.html
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-fixed-logical-height-only.html
@@ -26,21 +26,18 @@
#grid4 {
grid-template-columns: 30px;
grid-template-rows: minmax(20px, 80px) 60px;
- -webkit-writing-mode: vertical-rl;
}
#grid5 {
grid-template-columns: 30px;
/* 90% > 80px, 80px should be ignored. */
grid-template-rows: minmax(90%, 80px) minmax(10px, 60%);
- -webkit-writing-mode: vertical-lr;
}
#grid6 {
/* Overlapping range. */
grid-template-columns: 30px;
grid-template-rows: minmax(10px, 180px) minmax(30px, 150px);
- -webkit-writing-mode: horizontal-bt;
}
.firstRowFirstColumn {
@@ -74,17 +71,17 @@
<div class="secondRowFirstColumn" data-expected-height="110" data-expected-width="30"></div>
</div>
-<div class="grid" id="grid4" data-expected-width="100" data-expected-height="200">
+<div class="grid verticalRL" id="grid4" data-expected-width="100" data-expected-height="200">
<div class="firstRowFirstColumn" data-expected-height="30" data-expected-width="40"></div>
<div class="secondRowFirstColumn" data-expected-height="30" data-expected-width="60"></div>
</div>
-<div class="grid" id="grid5" data-expected-width="100" data-expected-height="200">
+<div class="grid verticalLR" id="grid5" data-expected-width="100" data-expected-height="200">
<div class="firstRowFirstColumn" data-expected-height="30" data-expected-width="90"></div>
<div class="secondRowFirstColumn" data-expected-height="30" data-expected-width="10"></div>
</div>
-<div class="grid" id="grid6" data-expected-width="100" data-expected-height="200">
+<div class="grid horizontalBT" id="grid6" data-expected-width="100" data-expected-height="200">
<div class="firstRowFirstColumn" data-expected-height="90" data-expected-width="30"></div>
<div class="secondRowFirstColumn" data-expected-height="110" data-expected-width="30"></div>
</div>

Powered by Google App Engine
This is Rietveld 408576698