third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-columns.html - Issue 1488493003: [css-grid] refactoring of layout tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-columns.html

Issue 1488493003: [css-grid] refactoring of layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch rebased and refactoring of alignment css rules. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-fixed-logical-width-only.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/minmax-max-content-resolution-rows.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <link href="resources/grid.css" rel="stylesheet">	3 <link href="resources/grid.css" rel="stylesheet">

4 <style>	4 <style>

5 .gridMinMaxContent {	5 .gridMinMaxContent {

6 grid-template-columns: minmax(max-content, 50px);	6 grid-template-columns: minmax(max-content, 50px);

7 grid-template-rows: 60px;	7 grid-template-rows: 60px;

8 }	8 }

9	9

10 .gridMaxMaxContent {	10 .gridMaxMaxContent {

11 grid-template-columns: minmax(30px, max-content);	11 grid-template-columns: minmax(30px, max-content);

12 grid-template-rows: 20px;	12 grid-template-rows: 20px;

13 }	13 }

14	14

15 .firstRowFirstColumn {	15 .firstRowFirstColumn {

16 font: 10px/1 Ahem;	16 font: 10px/1 Ahem;

17 /* Make us fit our grid area. */	17 /* Make us fit our grid area. */

18 width: 100%;	18 width: 100%;

19 height: 100%;	19 height: 100%;

20 }	20 }

21

22 .verticalRL {

23 -webkit-writing-mode: vertical-rl;

24 }

25 </style>	21 </style>

26 <script src="../../resources/check-layout.js"></script>	22 <script src="../../resources/check-layout.js"></script>

27 <body onload="checkLayout('.gridMinMaxContent'); checkLayout('.gridMaxMaxContent ')">	23 <body onload="checkLayout('.gridMinMaxContent'); checkLayout('.gridMaxMaxContent ')">

28	24

29 <p>Test that resolving minmax function with max-content on grid items works prop erly.</p>	25 <p>Test that resolving minmax function with max-content on grid items works prop erly.</p>

30	26

31 <div class="constrainedContainer">	27 <div class="constrainedContainer">

32 <div class="grid gridMinMaxContent">	28 <div class="grid gridMinMaxContent">

33 <div class="firstRowFirstColumn" data-expected-width="30" data-expected- height="60">XXX</div>	29 <div class="firstRowFirstColumn" data-expected-width="30" data-expected- height="60">XXX</div>

34 </div>	30 </div>

(...skipping 54 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
89	85

90 <div style="width: 100px; height: 20px">	86 <div style="width: 100px; height: 20px">

91 <div class="grid gridMaxMaxContent">	87 <div class="grid gridMaxMaxContent">

92 <!-- The 'max' logical width ends up being smaller than the 'min' so per the spec we ignore the 'max'. -->	88 <!-- The 'max' logical width ends up being smaller than the 'min' so per the spec we ignore the 'max'. -->

93 <div class="firstRowFirstColumn" data-expected-width="30" data-expected- height="20">XX</div>	89 <div class="firstRowFirstColumn" data-expected-width="30" data-expected- height="20">XX</div>

94 </div>	90 </div>

95 </div>	91 </div>

96	92

97 </body>	93 </body>

98 </html>	94 </html>

OLD	NEW