Unify InvokeBuiltin implementations across architectures.

Unify InvokeBuiltin implementations across architectures.

This makes the implementations of MacroAssembler::InvokeBuiltin go
through the InvokeFunctionCode helper on all architectures. This helper
knows how to correctly set up all registers (i.e. argument count and the
new target value).

R=bmeurer@chromium.org

Committed: https://crrev.com/35b47d89f64872265290d344278a834fff1626ef
Cr-Commit-Position: refs/heads/master@{#32646}

[Michael Starzinger, 2015-12-04 15:12:08]

Note that on some architectures this adds one instruction to InvokeBuiltin
sequence, which initializes the arguments count register. For builtin
invocations this register is not needed AFAICT. So I am unsure whether we want
this change in it's current form or not. But we definitely should make it
uniform on all architectures. Please advise accordingly.

[Michael Starzinger, 2015-12-04 16:37:08]

Description was changed from

==========
Unify InvokeBuiltin implementations accross architectures.

This makes the implementations of MacroAssembler::InvokeBuiltin go
through the InvokeFunctionCode helper on all architectures. This helper
knows how to correctly set up all registers (i.e. argument count and the
new target value).

R=bmeurer@chromium.org
==========

to

==========
Unify InvokeBuiltin implementations across architectures.

This makes the implementations of MacroAssembler::InvokeBuiltin go
through the InvokeFunctionCode helper on all architectures. This helper
knows how to correctly set up all registers (i.e. argument count and the
new target value).

R=bmeurer@chromium.org
==========

[Benedikt Meurer, 2015-12-07 04:45:53]

Nice, I like it. LGTM.
I hope that long-term we can eliminate this mechanism completely (we still have
4 builtins left waiting to be killed, but those are the "hard ones").

[Michael Starzinger, 2015-12-07 09:24:59]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-12-07 09:25:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488303008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488303008/1

[commit-bot: I haz the power, 2015-12-07 09:26:18]

Description was changed from

==========
Unify InvokeBuiltin implementations across architectures.

This makes the implementations of MacroAssembler::InvokeBuiltin go
through the InvokeFunctionCode helper on all architectures. This helper
knows how to correctly set up all registers (i.e. argument count and the
new target value).

R=bmeurer@chromium.org
==========

to

==========
Unify InvokeBuiltin implementations across architectures.

This makes the implementations of MacroAssembler::InvokeBuiltin go
through the InvokeFunctionCode helper on all architectures. This helper
knows how to correctly set up all registers (i.e. argument count and the
new target value).

R=bmeurer@chromium.org
==========

[commit-bot: I haz the power, 2015-12-07 09:26:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-07 09:27:12]

Description was changed from

==========
Unify InvokeBuiltin implementations across architectures.

This makes the implementations of MacroAssembler::InvokeBuiltin go
through the InvokeFunctionCode helper on all architectures. This helper
knows how to correctly set up all registers (i.e. argument count and the
new target value).

R=bmeurer@chromium.org
==========

to

==========
Unify InvokeBuiltin implementations across architectures.

This makes the implementations of MacroAssembler::InvokeBuiltin go
through the InvokeFunctionCode helper on all architectures. This helper
knows how to correctly set up all registers (i.e. argument count and the
new target value).

R=bmeurer@chromium.org

Committed: https://crrev.com/35b47d89f64872265290d344278a834fff1626ef
Cr-Commit-Position: refs/heads/master@{#32646}
==========

[commit-bot: I haz the power, 2015-12-07 09:27:13]

Patchset 1 (id:??) landed as
https://crrev.com/35b47d89f64872265290d344278a834fff1626ef
Cr-Commit-Position: refs/heads/master@{#32646}