Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1499953002: Fix uninitialized new.target register in InvokeBuiltin. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix uninitialized new.target register in InvokeBuiltin. On some architectures the InvokeBuiltin sequence does not go through InvokeFunctionCode, which initializes the new.target register. This initializes the register explicitly on these architectures for now. R=ishell@chromium.org BUG=chromium:565046 LOG=n Committed: https://crrev.com/77774035d85d9d7df2cb09a77bca45ce7c938482 Cr-Commit-Position: refs/heads/master@{#32622}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
5 years ago (2015-12-04 14:53:22 UTC) #3
Igor Sheludko
lgtm
5 years ago (2015-12-04 16:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499953002/20001
5 years ago (2015-12-04 16:34:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-04 16:35:40 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-04 16:35:57 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77774035d85d9d7df2cb09a77bca45ce7c938482
Cr-Commit-Position: refs/heads/master@{#32622}

Powered by Google App Engine
This is Rietveld 408576698