Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: src/arm64/macro-assembler-arm64.cc

Issue 1488303008: Unify InvokeBuiltin implementations across architectures. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_issue-cr-565046
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm64/macro-assembler-arm64.cc
diff --git a/src/arm64/macro-assembler-arm64.cc b/src/arm64/macro-assembler-arm64.cc
index c561e26feec4d3bf5d5672d526b21da32ab312f3..b5d52bdf3d0fe0ea345b0d7a17b1f3947a431484 100644
--- a/src/arm64/macro-assembler-arm64.cc
+++ b/src/arm64/macro-assembler-arm64.cc
@@ -1707,20 +1707,10 @@ void MacroAssembler::InvokeBuiltin(int native_context_index, InvokeFlag flag,
// You can't call a builtin without a valid frame.
DCHECK(flag == JUMP_FUNCTION || has_frame());
- // Always initialize new target.
- LoadRoot(x3, Heap::kUndefinedValueRootIndex);
-
- // Get the builtin entry in x2 and setup the function object in x1.
+ // Fake a parameter count to avoid emitting code to do the check.
+ ParameterCount expected(0);
LoadNativeContextSlot(native_context_index, x1);
- Ldr(x2, FieldMemOperand(x1, JSFunction::kCodeEntryOffset));
- if (flag == CALL_FUNCTION) {
- call_wrapper.BeforeCall(CallSize(x2));
- Call(x2);
- call_wrapper.AfterCall();
- } else {
- DCHECK(flag == JUMP_FUNCTION);
- Jump(x2);
- }
+ InvokeFunctionCode(x1, no_reg, expected, expected, flag, call_wrapper);
}
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698