Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 14875002: Add support for GL_*_shader_framebuffer_fetch (Closed)

Created:
7 years, 7 months ago by bsalomon
Modified:
7 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add support for GL_*_shader__framebuffer_fetch R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=8980

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -17 lines) Patch
M src/gpu/GrDrawTarget.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 3 chunks +16 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 5 chunks +32 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 6 chunks +34 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
7 years, 7 months ago (2013-05-02 21:14:59 UTC) #1
robertphillips
lgtm
7 years, 7 months ago (2013-05-02 21:22:08 UTC) #2
robertphillips
Any performance numbers on this?
7 years, 7 months ago (2013-05-02 21:22:27 UTC) #3
bsalomon
On 2013/05/02 21:22:27, robertphillips wrote: > Any performance numbers on this? On a N7: PRE: ...
7 years, 7 months ago (2013-05-03 13:32:07 UTC) #4
bsalomon
On 2013/05/03 13:32:07, bsalomon wrote: > On 2013/05/02 21:22:27, robertphillips wrote: > > Any performance ...
7 years, 7 months ago (2013-05-03 13:33:03 UTC) #5
bsalomon
7 years, 7 months ago (2013-05-03 13:35:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r8980 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698