Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1487413002: V8 Buildbot: Correctly set properties of triggered tryjobs. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org, nodir
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M scripts/slave/recipe_modules/v8/api.py View 1 1 chunk +7 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/v8/test_api.py View 1 1 chunk +4 lines, -1 line 2 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json View 1 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Achenbach
PTAL
5 years ago (2015-12-02 12:35:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487413002/20001
5 years ago (2015-12-02 12:51:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=297785
5 years ago (2015-12-02 12:53:53 UTC) #7
tandrii(chromium)
LGTM https://codereview.chromium.org/1487413002/diff/20001/scripts/slave/recipe_modules/v8/test_api.py File scripts/slave/recipe_modules/v8/test_api.py (right): https://codereview.chromium.org/1487413002/diff/20001/scripts/slave/recipe_modules/v8/test_api.py#newcode401 scripts/slave/recipe_modules/v8/test_api.py:401: reason='CQ', not sure it's capital or not, but ...
5 years ago (2015-12-02 13:02:10 UTC) #8
Michael Achenbach
5 years ago (2015-12-02 13:06:02 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/1487413002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/v8/test_api.py (right):

https://codereview.chromium.org/1487413002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/v8/test_api.py:401: reason='CQ',
On 2015/12/02 13:02:10, tandrii(chromium) wrote:
> not sure it's capital or not, but CQ certainly doesn't care.

No idea where it's set in production, but I took prod data for the test:
https://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/103

Powered by Google App Engine
This is Rietveld 408576698