Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: scripts/slave/recipe_modules/v8/api.py

Issue 1487413002: V8 Buildbot: Correctly set properties of triggered tryjobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/v8/api.py
diff --git a/scripts/slave/recipe_modules/v8/api.py b/scripts/slave/recipe_modules/v8/api.py
index 1775ba98a641aa01bf765741688eaeddb89faae9..051de3cd9c690da6c9e20515f9d1d5b281b32e5c 100644
--- a/scripts/slave/recipe_modules/v8/api.py
+++ b/scripts/slave/recipe_modules/v8/api.py
@@ -1009,13 +1009,20 @@ class V8Api(recipe_api.RecipeApi):
}
if self.m.tryserver.is_tryserver:
properties.update(
+ category=self.m.properties['category'],
issue=self.m.properties['issue'],
+ master=str(self.m.properties['master']),
patch_project=str(self.m.properties['patch_project']),
patch_storage=str(self.m.properties['patch_storage']),
patchset=str(self.m.properties['patchset']),
+ reason=str(self.m.properties['reason']),
requester=str(self.m.properties['requester']),
rietveld=str(self.m.properties['rietveld']),
)
+
+ # TODO(machenbach): Also set meaningful buildbucket tags of triggering
+ # parent.
+
swarm_hashes = self.m.isolate.isolated_tests
if swarm_hashes:
properties['swarm_hashes'] = swarm_hashes
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/test_api.py » ('j') | scripts/slave/recipe_modules/v8/test_api.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698