Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: scripts/slave/recipe_modules/v8/test_api.py

Issue 1487413002: V8 Buildbot: Correctly set properties of triggered tryjobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Exposes the builder and recipe configurations to GenTests in recipes. 5 # Exposes the builder and recipe configurations to GenTests in recipes.
6 6
7 import re 7 import re
8 8
9 from recipe_engine import recipe_test_api 9 from recipe_engine import recipe_test_api
10 from . import builders 10 from . import builders
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 if bot_config.get('enable_swarming'): 387 if bot_config.get('enable_swarming'):
388 # Assume each tester is triggered with the required hashes for all 388 # Assume each tester is triggered with the required hashes for all
389 # tests. 389 # tests.
390 test += self.m.properties( 390 test += self.m.properties(
391 parent_got_swarming_client_revision='[dummy swarming client hash]', 391 parent_got_swarming_client_revision='[dummy swarming client hash]',
392 swarm_hashes=self._make_dummy_swarm_hashes(bot_config), 392 swarm_hashes=self._make_dummy_swarm_hashes(bot_config),
393 ) 393 )
394 394
395 if mastername.startswith('tryserver'): 395 if mastername.startswith('tryserver'):
396 test += self.m.properties( 396 test += self.m.properties(
397 revision='12345', 397 category='cq',
398 master='tryserver.v8',
398 patch_project='v8', 399 patch_project='v8',
399 patch_storage='rietveld', 400 patch_storage='rietveld',
401 reason='CQ',
tandrii(chromium) 2015/12/02 13:02:10 not sure it's capital or not, but CQ certainly doe
Michael Achenbach 2015/12/02 13:06:01 No idea where it's set in production, but I took p
402 revision='12345',
400 try_job_key='1234', 403 try_job_key='1234',
401 ) 404 )
402 405
403 return test 406 return test
404 407
405 def fail(self, step_name): 408 def fail(self, step_name):
406 return self.override_step_data( 409 return self.override_step_data(
407 step_name, self.failures_example()) 410 step_name, self.failures_example())
408 411
409 def stdout(self, step_name, output, retcode=0): 412 def stdout(self, step_name, output, retcode=0):
(...skipping 29 matching lines...) Expand all
439 @staticmethod 442 @staticmethod
440 def perf_failures(has_failures): 443 def perf_failures(has_failures):
441 return has_failures 444 return has_failures
442 445
443 def __call__(self, test_failures=False, wrong_results=False, 446 def __call__(self, test_failures=False, wrong_results=False,
444 perf_failures=False, flakes=False): 447 perf_failures=False, flakes=False):
445 return (self.test_failures(test_failures) + 448 return (self.test_failures(test_failures) +
446 self.wrong_results(wrong_results) + 449 self.wrong_results(wrong_results) +
447 self.flakes(flakes) + 450 self.flakes(flakes) +
448 self.perf_failures(perf_failures)) 451 self.perf_failures(perf_failures))
OLDNEW
« no previous file with comments | « scripts/slave/recipe_modules/v8/api.py ('k') | scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698