chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adress feedback Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_window.h ('K') | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/sync/one_click_signin_sync_starter.h » ('j') | chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index c1982e0ca15676ed4031b14d21b48c46fbc9e985..612d7c3d06489e4b6fb1090f1755aad88a9c62a0 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -853,10 +853,15 @@ void BrowserWindowCocoa::ShowAvatarBubbleFromAvatarButton(

void BrowserWindowCocoa::ShowModalSigninWindow(AvatarBubbleMode mode) {

NOTREACHED();

}

void BrowserWindowCocoa::CloseModalSigninWindow() {

NOTREACHED();

}

+void BrowserWindowCocoa::ShowModalSyncConfirmationWindow() {

+ NOTREACHED();

int

BrowserWindowCocoa::GetRenderViewHeightInsetWithDetachedBookmarkBar() {

if (browser_->bookmark_bar_state() != BookmarkBar::DETACHED)