chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc - Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adress feedback Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_window.h ('K') | « chrome/browser/ui/views/profiles/signin_view_controller.cc ('k') | chrome/browser/ui/webui/signin/login_ui_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

index a148b21ba7d413ac298bf7285851477d81c43b9a..46740458acaee56e277516e13a76cd15058618a5 100644

--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

@@ -50,6 +50,7 @@

#include "chrome/browser/ui/webui/settings/md_settings_ui.h"

#include "chrome/browser/ui/webui/signin/inline_login_ui.h"

#include "chrome/browser/ui/webui/signin/profile_signin_confirmation_ui.h"

+#include "chrome/browser/ui/webui/signin/sync_confirmation_ui.h"

#include "chrome/browser/ui/webui/signin/user_manager_ui.h"

#include "chrome/browser/ui/webui/signin_internals_ui.h"

#include "chrome/browser/ui/webui/supervised_user_internals_ui.h"

@@ -498,6 +499,8 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,

return &NewWebUI<CopresenceUI>;

if (url.host() == chrome::kChromeUIChromeSigninHost)

return &NewWebUI<InlineLoginUI>;

+ if (url.host() == "sync-confirmation")

Dan Beam 2016/01/06 22:57:57 why are you not using a constant here?

anthonyvd 2016/01/08 22:39:41 Slipped through the cracks, thanks. Done.

+ return &NewWebUI<SyncConfirmationUI>;

if (url.SchemeIs(content::kChromeDevToolsScheme))

return &NewWebUI<DevToolsUI>;

if (url.host() == chrome::kChromeUIWebRTCDeviceProviderHost)