chrome/browser/ui/browser_window.h - Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_window.h

Issue 1487283005: Implement the new Sync Confirmation dialog on Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adress feedback Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/sync_confirmation/sync_confirmation.css ('K') | « chrome/browser/resources/sync_confirmation/sync_confirmation.js ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_window.h

diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h

index b334c083c5d17408c0ea3d18c63245a7421d58e9..b956544fdaebe0396d6e647bc54bfa3ef088b164 100644

--- a/chrome/browser/ui/browser_window.h

+++ b/chrome/browser/ui/browser_window.h

@@ -394,6 +394,8 @@ class BrowserWindow : public ui::BaseWindow {

// open. Does nothing otherwise.

virtual void CloseModalSigninWindow() = 0;

+ virtual void ShowModalSyncConfirmationWindow() = 0;

Robert Sesek 2015/12/04 17:29:58 This should have a comment (all other methods in t

anthonyvd 2015/12/04 22:42:06 Done.

// Returns the height inset for RenderView when detached bookmark bar is

// shown. Invoked when a new RenderHostView is created for a non-NTP

// navigation entry and the bookmark bar is detached.