Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 14859006: Use PRIx64 instead of PRIxPTR for uint64 in deep-heap-profile. (Closed)

Created:
7 years, 7 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org, bulach
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use PRIx64 instead of PRIxPTR for uint64 in deep-heap-profile. BUG=162208 R=jyasskin@chromium.org, willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199471

Patch Set 1 #

Patch Set 2 : always PRIx64 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/tcmalloc/chromium/src/deep-heap-profile.cc View 1 1 chunk +2 lines, -2 lines 4 comments Download

Messages

Total messages: 7 (0 generated)
Dai Mikurube (NOT FULLTIME)
Just a nit fix. Could you take a look when you have time?
7 years, 7 months ago (2013-05-07 10:56:57 UTC) #1
willchan no longer on Chromium
I always forget these macros, but I trust jyasskin@ when he says it's right/wrong. Jeffrey, ...
7 years, 7 months ago (2013-05-09 21:06:06 UTC) #2
Jeffrey Yasskin
lgtm https://codereview.chromium.org/14859006/diff/2001/third_party/tcmalloc/chromium/src/deep-heap-profile.cc File third_party/tcmalloc/chromium/src/deep-heap-profile.cc (right): https://codereview.chromium.org/14859006/diff/2001/third_party/tcmalloc/chromium/src/deep-heap-profile.cc#newcode363 third_party/tcmalloc/chromium/src/deep-heap-profile.cc:363: bool DeepHeapProfile::TextBuffer::AppendPtr(uint64 v, int d) { Another possible ...
7 years, 7 months ago (2013-05-10 00:52:08 UTC) #3
Dai Mikurube (NOT FULLTIME)
Thanks for the comments, Jeffrey. I'll be committing it. https://codereview.chromium.org/14859006/diff/2001/third_party/tcmalloc/chromium/src/deep-heap-profile.cc File third_party/tcmalloc/chromium/src/deep-heap-profile.cc (right): https://codereview.chromium.org/14859006/diff/2001/third_party/tcmalloc/chromium/src/deep-heap-profile.cc#newcode363 third_party/tcmalloc/chromium/src/deep-heap-profile.cc:363: ...
7 years, 7 months ago (2013-05-10 09:45:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/14859006/2001
7 years, 7 months ago (2013-05-10 09:48:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/14859006/2001
7 years, 7 months ago (2013-05-10 12:23:04 UTC) #6
Dai Mikurube (NOT FULLTIME)
7 years, 7 months ago (2013-05-10 13:23:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r199471 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698