Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/tcmalloc/chromium/src/deep-heap-profile.cc

Issue 14859006: Use PRIx64 instead of PRIxPTR for uint64 in deep-heap-profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: always PRIx64 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/tcmalloc/chromium/src/deep-heap-profile.cc
diff --git a/third_party/tcmalloc/chromium/src/deep-heap-profile.cc b/third_party/tcmalloc/chromium/src/deep-heap-profile.cc
index 7201c8f2245d54b50efec136f36815f533140035..a2b1e35d13dd8ac81e7d0c747d700dd4d4aa4943 100644
--- a/third_party/tcmalloc/chromium/src/deep-heap-profile.cc
+++ b/third_party/tcmalloc/chromium/src/deep-heap-profile.cc
@@ -363,9 +363,9 @@ bool DeepHeapProfile::TextBuffer::AppendInt64(int64 v, int d) {
bool DeepHeapProfile::TextBuffer::AppendPtr(uint64 v, int d) {
Jeffrey Yasskin 2013/05/10 00:52:08 Another possible fix would be to change this to ui
Dai Mikurube (NOT FULLTIME) 2013/05/10 09:45:53 Yeah, it might be better, but we decided to use ui
int appended;
if (d == 0)
- appended = snprintf(buffer_ + cursor_, size_ - cursor_, "%"PRIxPTR, v);
+ appended = snprintf(buffer_ + cursor_, size_ - cursor_, "%"PRIx64, v);
Jeffrey Yasskin 2013/05/10 00:52:08 We'll eventually, probably, need to add a space be
Dai Mikurube (NOT FULLTIME) 2013/05/10 09:45:53 Ok.
else
- appended = snprintf(buffer_ + cursor_, size_ - cursor_, "%0*"PRIxPTR, d, v);
+ appended = snprintf(buffer_ + cursor_, size_ - cursor_, "%0*"PRIx64, d, v);
return ForwardCursor(appended);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698