media/base/sample_format.cc - Issue 148553003: Clean up histogram'd media enum max values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/sample_format.cc

Issue 148553003: Clean up histogram'd media enum max values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/sample_format.cc

diff --git a/media/base/sample_format.cc b/media/base/sample_format.cc

index a4791cd6861ef5dbb86f0edfe0fa7ce2f0459383..cf8f20f5632f2c8d19531c35433f3968c46f5261 100644

--- a/media/base/sample_format.cc

+++ b/media/base/sample_format.cc

@@ -21,8 +21,6 @@ int SampleFormatToBytesPerChannel(SampleFormat sample_format) {

case kSampleFormatF32:

case kSampleFormatPlanarF32:

return 4;

- case kSampleFormatMax:

- break;

}

NOTREACHED() << "Invalid sample format provided: " << sample_format;

@@ -45,8 +43,6 @@ const char* SampleFormatToString(SampleFormat sample_format) {

return "Signed 16-bit planar";

case kSampleFormatPlanarF32:

return "Float 32-bit planar";

- case kSampleFormatMax:

- break;

}

NOTREACHED() << "Invalid sample format provided: " << sample_format;

return "";