media/ffmpeg/ffmpeg_common.cc - Issue 148553003: Clean up histogram'd media enum max values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/ffmpeg/ffmpeg_common.cc

Issue 148553003: Clean up histogram'd media enum max values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment to ignore violations of PRESUBMIT. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/ffmpeg/ffmpeg_common.cc

diff --git a/media/ffmpeg/ffmpeg_common.cc b/media/ffmpeg/ffmpeg_common.cc

index 6e7bd155cd80d9f103cfbd7670e8e5381263cd3e..371193b62abebbf992767e4a5f5a82f33cef7d42 100644

--- a/media/ffmpeg/ffmpeg_common.cc

+++ b/media/ffmpeg/ffmpeg_common.cc

@@ -391,7 +391,7 @@ void AVStreamToVideoDecoderConfig(

if (record_stats) {

UMA_HISTOGRAM_ENUMERATION("Media.VideoColorRange",

stream->codec->color_range,

- AVCOL_RANGE_NB);

+ AVCOL_RANGE_NB); // PRESUBMIT_IGNORE_UMA_MAX

Ami GONE FROM CHROMIUM 2014/02/12 20:26:48 NOTE why IGNORE (like the other comment)

}

VideoFrame::Format format = PixelFormatToVideoFormat(stream->codec->pix_fmt);