media/filters/audio_renderer_impl.cc - Issue 148553003: Clean up histogram'd media enum max values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/audio_renderer_impl.cc

Issue 148553003: Clean up histogram'd media enum max values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment to ignore violations of PRESUBMIT. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/audio_renderer_impl.cc

diff --git a/media/filters/audio_renderer_impl.cc b/media/filters/audio_renderer_impl.cc

index f08ef83b418a5fb97808f973c9428ee899243817..a41f691736b36d486e0f7d793b22a59c756855a0 100644

--- a/media/filters/audio_renderer_impl.cc

+++ b/media/filters/audio_renderer_impl.cc

@@ -27,11 +27,11 @@ namespace {

enum AudioRendererEvent {

INITIALIZED,

RENDER_ERROR,

- MAX_EVENTS

+ MAX_EVENTS = RENDER_ERROR,

Ami GONE FROM CHROMIUM 2014/02/12 20:26:48 EVENT_MAX ?

};

void HistogramRendererEvent(AudioRendererEvent event) {

- UMA_HISTOGRAM_ENUMERATION("Media.AudioRendererEvents", event, MAX_EVENTS);

+ UMA_HISTOGRAM_ENUMERATION("Media.AudioRendererEvents", event, MAX_EVENTS + 1);

}

} // namespace