Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 14851014: [nacltoons] Move nacl-specific build to proj.nacl (Closed)

Created:
7 years, 7 months ago by Sam Clegg
Modified:
7 years, 7 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[nacltoons] Move nacl-specific build to proj.nacl Also, move win32 specific code to proj.win32. R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -321 lines) Patch
M nacltoons/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
D nacltoons/game.mk View 1 chunk +0 lines, -168 lines 0 comments Download
A + nacltoons/proj.nacl/Makefile View 7 chunks +30 lines, -25 lines 0 comments Download
A + nacltoons/proj.nacl/main.cc View 2 chunks +0 lines, -39 lines 0 comments Download
A nacltoons/proj.win/main.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M nacltoons/proj.win/nacltoons/nacltoons.vcxproj View 2 chunks +2 lines, -2 lines 0 comments Download
D nacltoons/src/main.cc View 1 chunk +0 lines, -85 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
7 years, 7 months ago (2013-05-07 21:18:45 UTC) #1
binji
lgtm
7 years, 7 months ago (2013-05-07 21:23:03 UTC) #2
Sam Clegg
7 years, 7 months ago (2013-05-07 21:23:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1547 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698