Issue 1485023003: Misc truncation fixes for gn builds with VS 2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1485023003: Misc truncation fixes for gn builds with VS 2015 (Closed)

Created:
5 years ago by brucedawson

Modified:
4 years, 10 months ago

Reviewers:

CC:
chromium-reviews, posciak+watch_chromium.org, samuong+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Misc truncation fixes for gn builds with VS 2015 These changes are enough to get the chrome, components, and content portions of Chromium building with VS 2015 in gn builds. The changes are all to fix warnings about truncation from size_t to smaller types. BUG=440500

Patch Set 1 #

Patch Set 2 : Fixes to four more components/content files #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -15 lines)			Patch
M	chrome/browser/media/webrtc_rtp_dump_writer.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/key_converter_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/chromedriver/util.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	components/gcm_driver/crypto/gcm_message_cryptographer.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	components/history/core/browser/history_backend_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/accessibility/browser_accessibility_win.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/indexed_db/indexed_db_leveldb_coding.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host_tcp.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host_test_utils.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

brucedawson

5 years ago (2015-12-02 01:01:10 UTC) #1

Description was changed from

==========
Misc truncation fixes for gn builds with 64-bit VS 2015

These changes are enough to get the chrome, components, and content
portions of Chromium building with VS 2015 in 64-bit gn builds. The
changes are all to fix warnings about truncation from size_t to smaller
types.

BUG=440500
==========

to

==========
Misc truncation fixes for gn builds with VS 2015

These changes are enough to get the chrome, components, and content
portions of Chromium building with VS 2015 in gn builds. The changes
are all to fix warnings about truncation from size_t to smaller types.

BUG=440500
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages