content/browser/indexed_db/indexed_db_leveldb_coding.cc - Issue 1485023003: Misc truncation fixes for gn builds with VS 2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_leveldb_coding.cc

Issue 1485023003: Misc truncation fixes for gn builds with VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes to four more components/content files Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/indexed_db/indexed_db_leveldb_coding.cc

diff --git a/content/browser/indexed_db/indexed_db_leveldb_coding.cc b/content/browser/indexed_db/indexed_db_leveldb_coding.cc

index f4d01dec591a6107113f547bc12b80b71d3ccd83..ccf792cacc73409e7ea7accd4b8f9c2bcb1f4438 100644

--- a/content/browser/indexed_db/indexed_db_leveldb_coding.cc

+++ b/content/browser/indexed_db/indexed_db_leveldb_coding.cc

@@ -1251,11 +1251,11 @@ std::string KeyPrefix::EncodeInternal(int64 database_id,

DCHECK(object_store_id_string.size() <= kMaxObjectStoreIdSizeBytes);

DCHECK(index_id_string.size() <= kMaxIndexIdSizeBytes);

- unsigned char first_byte =

+ unsigned char first_byte = static_cast<char>(

(database_id_string.size() - 1) << (kMaxObjectStoreIdSizeBits +

kMaxIndexIdSizeBits) |

(object_store_id_string.size() - 1) << kMaxIndexIdSizeBits |

- (index_id_string.size() - 1);

+ (index_id_string.size() - 1));

static_assert(kMaxDatabaseIdSizeBits + kMaxObjectStoreIdSizeBits +

kMaxIndexIdSizeBits ==

sizeof(first_byte) * 8,