components/history/core/browser/history_backend_unittest.cc - Issue 1485023003: Misc truncation fixes for gn builds with VS 2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_backend_unittest.cc

Issue 1485023003: Misc truncation fixes for gn builds with VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes to four more components/content files Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/history_backend_unittest.cc

diff --git a/components/history/core/browser/history_backend_unittest.cc b/components/history/core/browser/history_backend_unittest.cc

index 7c8ac3f9a2eb64ec1eb50e15676bb401568a337c..b4e9e499d262ca3073ef15f6acb8dbf3518342d0 100644

--- a/components/history/core/browser/history_backend_unittest.cc

+++ b/components/history/core/browser/history_backend_unittest.cc

@@ -2325,7 +2325,7 @@ TEST_F(HistoryBackendTest, MergeFaviconMaxFaviconBitmapsPerIconURL) {

int pixel_size = 1;

for (size_t i = 0; i < kMaxFaviconBitmapsPerIconURL + 1; ++i) {

- icon_url_string[replace_index] = '0' + i;

+ icon_url_string[replace_index] = '0' + static_cast<char>(i);

GURL icon_url(icon_url_string);

backend_->MergeFavicon(page_url,