Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2644)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1484883002: clang/arm: Push -no-integrated-as into the four targets that need it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 6923a32f1dd4c5f8e7a02b236df2251ebcd57615..08d10a494fa019f7002074a59b999a1a7405d730 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -588,13 +588,7 @@ config("compiler_codegen") {
]
}
} else if (current_cpu == "arm") {
- if (is_clang) {
- if (!is_android) {
- # We need to disable clang's builtin assembler as it can't
- # handle several asm files, crbug.com/124610
- cflags += [ "-no-integrated-as" ]
- }
- } else {
+ if (!is_clang) {
# Clang doesn't support these flags.
cflags += [
# The tree-sra optimization (scalar replacement for

Powered by Google App Engine
This is Rietveld 408576698