Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/libvpx_new/libvpx.gyp

Issue 1484883002: clang/arm: Push -no-integrated-as into the four targets that need it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/android/BUILD.gn ('K') | « third_party/libvpx_new/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libvpx_new/libvpx.gyp
diff --git a/third_party/libvpx_new/libvpx.gyp b/third_party/libvpx_new/libvpx.gyp
index c9133618914a4eff498030062708ef7f262a108d..edc87ab6a6a7ab3d2b8fbb0542ae55675ce20013 100644
--- a/third_party/libvpx_new/libvpx.gyp
+++ b/third_party/libvpx_new/libvpx.gyp
@@ -48,6 +48,15 @@
'shared_generated_dir': '<(SHARED_INTERMEDIATE_DIR)/third_party/libvpx_new',
},
'target_defaults': {
+ 'conditions': [
+ ['target_arch=="arm" and clang==1', {
+ # TODO(hans) Enable integrated-as (crbug.com/124610).
Johann 2015/12/01 15:26:18 We can generate clang-specific assembly. The issue
Nico 2015/12/01 15:32:28 clang's intentions are to support UAL from what I
+ 'cflags': [
+ '-fno-integrated-as',
+ '-B<(android_toolchain)', # Else /usr/bin/as gets picked up.
+ ],
+ }],
+ ],
'target_conditions': [
['<(libvpx_build_vp9)==0', {
'sources/': [ ['exclude', '(^|/)vp9/'], ],
« build/config/android/BUILD.gn ('K') | « third_party/libvpx_new/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698