Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1484883002: clang/arm: Push -no-integrated-as into the four targets that need it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/ccache.gni") 9 import("//build/toolchain/ccache.gni")
10 10
(...skipping 570 matching lines...) Expand 10 before | Expand all | Expand 10 after
581 # Else building libyuv gives clang's register allocator issues, 581 # Else building libyuv gives clang's register allocator issues,
582 # see llvm.org/PR15798 / crbug.com/233709 582 # see llvm.org/PR15798 / crbug.com/233709
583 "-momit-leaf-frame-pointer", 583 "-momit-leaf-frame-pointer",
584 584
585 # Align the stack on 16-byte boundaries, http://crbug.com/418554. 585 # Align the stack on 16-byte boundaries, http://crbug.com/418554.
586 "-mstack-alignment=16", 586 "-mstack-alignment=16",
587 "-mstackrealign", 587 "-mstackrealign",
588 ] 588 ]
589 } 589 }
590 } else if (current_cpu == "arm") { 590 } else if (current_cpu == "arm") {
591 if (is_clang) { 591 if (!is_clang) {
592 if (!is_android) {
593 # We need to disable clang's builtin assembler as it can't
594 # handle several asm files, crbug.com/124610
595 cflags += [ "-no-integrated-as" ]
596 }
597 } else {
598 # Clang doesn't support these flags. 592 # Clang doesn't support these flags.
599 cflags += [ 593 cflags += [
600 # The tree-sra optimization (scalar replacement for 594 # The tree-sra optimization (scalar replacement for
601 # aggregates enabling subsequent optimizations) leads to 595 # aggregates enabling subsequent optimizations) leads to
602 # invalid code generation when using the Android NDK's 596 # invalid code generation when using the Android NDK's
603 # compiler (r5-r7). This can be verified using 597 # compiler (r5-r7). This can be verified using
604 # webkit_unit_tests' WTF.Checked_int8_t test. 598 # webkit_unit_tests' WTF.Checked_int8_t test.
605 "-fno-tree-sra", 599 "-fno-tree-sra",
606 600
607 # The following option is disabled to improve binary 601 # The following option is disabled to improve binary
(...skipping 706 matching lines...) Expand 10 before | Expand all | Expand 10 after
1314 if (symbol_level == 0) { 1308 if (symbol_level == 0) {
1315 configs = [ ":no_symbols" ] 1309 configs = [ ":no_symbols" ]
1316 } else if (symbol_level == 1) { 1310 } else if (symbol_level == 1) {
1317 configs = [ ":minimal_symbols" ] 1311 configs = [ ":minimal_symbols" ]
1318 } else if (symbol_level == 2) { 1312 } else if (symbol_level == 2) {
1319 configs = [ ":symbols" ] 1313 configs = [ ":symbols" ]
1320 } else { 1314 } else {
1321 assert(false) 1315 assert(false)
1322 } 1316 }
1323 } 1317 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698