third_party/libaddressinput/chromium/cpp/test/fake_storage.h - Issue 148463003: libaddressinput - reduce number of copies in storage class by 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/chromium/cpp/test/fake_storage.h

Issue 148463003: libaddressinput - reduce number of copies in storage class by 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comment Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libaddressinput/chromium/cpp/test/fake_storage.h

diff --git a/third_party/libaddressinput/chromium/cpp/test/fake_storage.h b/third_party/libaddressinput/chromium/cpp/test/fake_storage.h

index 1987a2d2d19ec728d8a8d00e257a07a183a27d1b..bafb9a240e2675d787f49ec15284762f7b076451 100644

--- a/third_party/libaddressinput/chromium/cpp/test/fake_storage.h

+++ b/third_party/libaddressinput/chromium/cpp/test/fake_storage.h

@@ -34,7 +34,7 @@ namespace addressinput {

// ~MyClass() {}

// void Write() {

-// storage_.Put("key", "value");

+// storage_.Put("key", make_scoped_ptr(new std::string("value")));

// }

// void Read() {

@@ -58,7 +58,7 @@ class FakeStorage : public Storage {

virtual ~FakeStorage();

// Storage implementation.

- virtual void Put(const std::string& key, const std::string& data);

+ virtual void Put(const std::string& key, scoped_ptr<std::string> data);

virtual void Get(const std::string& key, scoped_ptr<Callback> data_ready)

const;